Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple positioner #123

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Simple positioner #123

merged 7 commits into from
Mar 29, 2024

Conversation

Topvennie
Copy link
Member

  • Adds the required classes / interfaces to be able to support multiple positioners.
  • Adds an example positioner

Closes #109

@Topvennie Topvennie requested review from FKD13 and redfast00 March 29, 2024 12:49
Comment on lines +8 to +19
@Getter @Setter
public class Position {
private int teamId;
private float progress; // Progress of the lap. Between 0-1
private float speed; // Current speed. Progress / second

public Position(int teamId) {
this.teamId = teamId;
this.progress = 0;
this.speed = 0;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do this like this

Suggested change
@Getter @Setter
public class Position {
private int teamId;
private float progress; // Progress of the lap. Between 0-1
private float speed; // Current speed. Progress / second
public Position(int teamId) {
this.teamId = teamId;
this.progress = 0;
this.speed = 0;
}
}
@Getter @Setter
public class Position {
private int teamId;
private float progress = 0; // Progress of the lap. Between 0-1
private float speed = 0; // Current speed. Progress / second
public Position(int teamId) {
this.teamId = teamId;
}
}

@Topvennie Topvennie merged commit 3a1953b into development Mar 29, 2024
1 check passed
@Topvennie Topvennie deleted the simple_positioner branch March 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Positioners
2 participants