feat(lapCountResource): add lap count per source & team #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End date should be the date of the postgres DB so in our normal settingg, the local time (UTC + 2)
FKD13
reviewed
Apr 2, 2024
FKD13
requested changes
Apr 3, 2024
FKD13
reviewed
Apr 5, 2024
| @@ -29,6 +30,14 @@ public interface LapDAO extends DAO<Lap> { | |||
| @RegisterBeanMapper(Lap.class) | |||
| List<Lap> getAllBySourceSorted(@Bind("lapSourceId") Integer lapSourceId); | |||
|
|
|||
| @SqlQuery("SELECT t.id as team_id, (SELECT COUNT(*) FROM lap WHERE lap_source_id = :lapSourceId AND timestamp <= :timestamp and team_id = t.id) as count FROM team t") | |||
There was a problem hiding this comment.
Suggested change
| @SqlQuery("SELECT t.id as team_id, (SELECT COUNT(*) FROM lap WHERE lap_source_id = :lapSourceId AND timestamp <= :timestamp and team_id = t.id) as count FROM team t") | |
| @SqlQuery("SELECT team_id, COUNT(*) FROM lap WHERE lap_source_id = :lapSourceId AND timestamp <= :timestamp GROUP BY team_id") |
| @RegisterBeanMapper(LapCount.class) | ||
| List<LapCount> getAllBeforeTime(@Bind("lapSourceId") Integer lapSourceId, @Bind("timestamp") Timestamp timestamp); | ||
|
|
||
| @SqlQuery("SELECT t.id as team_id, (SELECT COUNT(*) FROM lap WHERE lap_source_id = :lapSourceId AND timestamp <= :timestamp and team_id = t.id) as count FROM team t where id = :teamId") |
There was a problem hiding this comment.
Suggested change
| @SqlQuery("SELECT t.id as team_id, (SELECT COUNT(*) FROM lap WHERE lap_source_id = :lapSourceId AND timestamp <= :timestamp and team_id = t.id) as count FROM team t where id = :teamId") | |
| @SqlQuery("SELECT team_id, COUNT(*) FROM lap WHERE lap_source_id = :lapSourceId AND timestamp <= :timestamp and team_id = :teamId GROUP BY team_id") |
There was a problem hiding this comment.
The problem with GROUP BY is that it doesn't return anything if a team has zero laps
There was a problem hiding this comment.
Valid remark, I assumed data to always be there.
FKD13
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End date should be the date of the postgres DB so in our normal settingg, the local time (UTC + 2)
closes #110