Bug Impossible remove proposal that flow don't exist + improvments #8
Conversation
⚡ require custom error ⚡ fix tests for fork ⚡ internal storages all publics ⚡ new events and errors 🐛 try catchs ⚡ fix setup script
Yeah try catch make sure others proposals dont get blocked by one with error. 171 dont exist, so need be created new proposal for it, but if its possible to back in GV1, just need be registered, activated again and will work without problem. Not, its not a edge case, that was a bug, 171 was should be deleted but because the error never got deleted and create a inconsistent state, DoSing the contracts. High vuln |
| mapping(uint256 => Flow) internal flows; | ||
| mapping(uint256 => Proposal) internal registeredProposals; | ||
| mapping(address => bool) internal registeredBeneficiary; | ||
| uint256[15] internal activeProposals; | ||
| mapping(uint256 => Flow) public flows; | ||
| mapping(uint256 => Proposal) public registeredProposals; | ||
| mapping(address => bool) public registeredBeneficiary; | ||
| uint256[15] public activeProposals; |
There was a problem hiding this comment.
made all public to make easy to investigate the state of the contracts.
| event FlowUpdatedError(uint256 proposalId, address beneficiary, uint256 rate, bytes error); | ||
| event DeleteFlowFailed(uint256 proposalId, bytes error); |
There was a problem hiding this comment.
bytes error hold the original error
| function removeProposals(uint256[] memory _proposalIds) public onlyOwner { | ||
| for (uint256 i = 0; i < _proposalIds.length; i++) { | ||
| _removeProposal(_proposalIds[i]); | ||
| function removeProposals(uint256[] memory _proposalIndexes) public onlyOwner { |
There was a problem hiding this comment.
right name, that ints indexes and not ids
| require(_proposalId != 0, InvalidProposalId()); | ||
| require(_beneficiary != address(0), InvalidBeneficiaryAddress()); | ||
| require(!registeredBeneficiary[_beneficiary], BeneficiaryAlreadyRegistered()); |
| } catch (bytes memory error) { | ||
| // console.log("Flow update failed:"); | ||
| // console.logBytes(error); | ||
| emit FlowUpdatedError(_proposalId, registeredProposals[_proposalId].beneficiary, flow.lastRate, error); |
There was a problem hiding this comment.
avoid revert and DoS the contract
| // console.log("Proposal id %d", proposalId); | ||
| try superfluid.deleteFlow(token, registeredProposals[proposalId].beneficiary){ | ||
| // console.log("Flow deleted"); | ||
| }catch(bytes memory error){ |
There was a problem hiding this comment.
Flow not created error can happens by Superfluid side that can revert here without try catch and DoS the contract
| uint256 WRAP_AMOUNT = 100 ether; | ||
| uint256 CEILING_BSP = 250; // 2.5% of Common Pool expresed as Basis Points |
There was a problem hiding this comment.
matching the current values
✨ solidity 0.8.27 last version
⚡ require custom error
⚡ fix tests for fork
⚡ internal storages all publics
⚡ new events and errors
🐛 try catchs
⚡ fix setup script