Improved Redis configurations #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove init containers - remove volumes - refactor redis.conf as command arguments Signed-off-by: Adam Pike <adam.pike@1password.com>
- remove redundant Redis env var - override default Redis container command to configure Redis as cache Signed-off-by: Adam Pike <adam.pike@1password.com>
- remove redundant OP_REDIS_URL env var - add command-line args to configure Redis as cache - remove REDIS_ARGS env var Signed-off-by: Adam Pike <adam.pike@1password.com>
- override Redis container arguments to configure Redis as cache - remove redundant volumes, mounts from Redis Pod - remove redundant ConfigMap resource - update related docs references Signed-off-by: Adam Pike <adam.pike@1password.com>
- use library Redis - override container command to configure Redis as cache - remove redundant env vars Signed-off-by: Adam Pike <adam.pike@1password.com>
- refactor Redis to use service command to configure Redis as cache - remove redundant Docker config for Redis - remove redundant redis.conf source file for config - update relevant docs references Signed-off-by: Adam Pike <adam.pike@1password.com>
Signed-off-by: Adam Pike <adam.pike@1password.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the base configuration for the Redis instance included as part of our example SCIM Bridge deployments.
Container configuration varies by platform, but the strategy is similar for each:
The included changes do not significantly change functionality of the deployment examples, but reduce complexity, reduce lines of code, and make our examples more generic for customers that choose to use them as a base for their own customizations.
For review, existing deployment and update instructions should work as expected. Redis logs should not warn that configuration is missing, but should include "Configuration loaded" within the first few log lines after the container starts.