Address feedback

plugins/kaggle/api_token.go

@@ -1,6 +1,8 @@
 package kaggle
 
 import (
+	"context"
+
 	"github.com/1Password/shell-plugins/sdk"
 	"github.com/1Password/shell-plugins/sdk/importer"
 	"github.com/1Password/shell-plugins/sdk/provision"
@@ -42,10 +44,38 @@ func APIToken() schema.CredentialType {
 		DefaultProvisioner: provision.EnvVars(defaultEnvVarMapping),
 		Importer: importer.TryAll(
 			importer.TryEnvVarPair(defaultEnvVarMapping),
+			TryKaggleConfigFile("~/.kaggle/kaggle.json"),
 		)}
 }
 
 var defaultEnvVarMapping = map[string]sdk.FieldName{
 	"KAGGLE_KEY":      fieldname.Token,
 	"KAGGLE_USERNAME": fieldname.Username,
 }
+
+func TryKaggleConfigFile(path string) sdk.Importer {
+	return importer.TryFile(path, func(ctx context.Context, contents importer.FileContents, in sdk.ImportInput, out *sdk.ImportAttempt) {
+		var config Config
+		if err := contents.ToJSON(&config); err != nil {
+			out.AddError(err)
+			return
+		}
+
+		if config.Token == "" {
+			return
+		}
+
+		out.AddCandidate(sdk.ImportCandidate{
+			Fields: map[sdk.FieldName]string{
+				fieldname.Token:    config.Token,
+				fieldname.Username: config.Username,
+			},
+			NameHint: importer.SanitizeNameHint(config.Username),
+		})
+	})
+}
+
+type Config struct {
+	Username string `json:"username"`
+	Token    string `json:"key"`
+}

plugins/kaggle/api_token_test.go

@@ -24,3 +24,36 @@ func TestAPITokenProvisioner(t *testing.T) {
 		},
 	})
 }
+
+func TestAPITokenImporter(t *testing.T) {
+	plugintest.TestImporter(t, APIToken().Importer, map[string]plugintest.ImportCase{
+		"environment": {
+			Environment: map[string]string{
+				"KAGGLE_KEY":      "z2pifkruzgbb17plmz2gux21fexample",
+				"KAGGLE_USERNAME": "username",
+			},
+			ExpectedCandidates: []sdk.ImportCandidate{
+				{
+					Fields: map[sdk.FieldName]string{
+						fieldname.Token:    "z2pifkruzgbb17plmz2gux21fexample",
+						fieldname.Username: "username",
+					},
+				},
+			},
+		},
+		"config file": {
+			Files: map[string]string{
+				"~/.kaggle/kaggle.json": plugintest.LoadFixture(t, "config.json"),
+			},
+			ExpectedCandidates: []sdk.ImportCandidate{
+				{
+					Fields: map[sdk.FieldName]string{
+						fieldname.Token:    "z2pifkruzgbb17plmz2gux21fexample",
+						fieldname.Username: "username",
+					},
+					NameHint: "username",
+				},
+			},
+		},
+	})
+}

plugins/kaggle/test-fixtures/config.json

@@ -0,0 +1 @@
+{"username":"username","key":"z2pifkruzgbb17plmz2gux21fexample"}