Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vercel plugin #273

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: add vercel plugin #273

merged 1 commit into from
Jun 22, 2023

Conversation

j178
Copy link
Contributor

@j178 j178 commented May 29, 2023 •
edited
Loading

Overview

Add vercel plugin.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

How To Test

op plugin init vercel
op plugin run -- vercel whoami

hculea
hculea reviewed May 29, 2023
View reviewed changes
Copy link
Member

@hculea hculea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! ❤️ I've only got a few questions and couple suggestions.

plugins/vercel/api_token.go Show resolved Hide resolved
plugins/vercel/api_token_test.go Outdated Show resolved Hide resolved
plugins/vercel/vercel.go Show resolved Hide resolved
plugins/vercel/api_token.go Outdated Show resolved Hide resolved
hculea
hculea approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@hculea hculea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution! ❤️

@j178
Copy link
Contributor Author

j178 commented Jun 12, 2023

A gentle ping to @florisvdg, would you be willing to give this second approve and merge it?

@arunsathiya arunsathiya mentioned this pull request Jun 21, 2023
Closed
1 task
@AndyTitu
Copy link
Contributor

AndyTitu commented Jun 22, 2023 •
edited
Loading

Hey @j178 these commits seem to not have been verified and and therefore we cannot merge the PR yet. Could you amend those and sign them as you did with the rest of your commis?

9689e72
8a97ee1

@AndyTitu AndyTitu mentioned this pull request Jun 22, 2023
Merged
4 tasks
@j178
feat: vercel-cli support
574b0ae 
improve

fix tests

improve

fix test

Update docs url

Co-authored-by: Floris van der Grinten <floris@grinten.com>

not need auth if providing one
@j178
Copy link
Contributor Author

j178 commented Jun 22, 2023

@AndyTitu Hi, I rebased and signed all the commits, thanks.

@AndyTitu AndyTitu merged commit 9517135 into 1Password:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hculea hculea hculea approved these changes

@florisvdg florisvdg florisvdg approved these changes

Assignees
No one assigned
Labels
waiting-on-sec-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j178 @AndyTitu @florisvdg @hculea