Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(mongosh): Support mongosh executable for connecting to a MongoDB database #283

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

new(mongosh): Support mongosh executable for connecting to a MongoDB database #283

wants to merge 22 commits into from

Commits on Aug 17, 2023

  1. Introduce a new arguments provisioner and a new chained provision tha… 

    …t stitches together multiple provisioners
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    0dfdf01 View commit details
    Browse the repository at this point in the history

  2. Reintroduce AddArgs helper function and fix FileProvisioner breakage

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4bc9efd View commit details
    Browse the repository at this point in the history

  3. Initial setup with DatabaseCredentials credential and mongosh executable

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c4b198d View commit details
    Browse the repository at this point in the history

  4. Configure arguments to provision and index to provision at

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e602f5f View commit details
    Browse the repository at this point in the history

  5. Branch out MongoDB Atlas and MongoDB Shell as separate shell plugins,… 

    … and rename atlas plugin to mongodbatlas, in line with the other one being named mongodbshell
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    bb7d075 View commit details
    Browse the repository at this point in the history

  6. Switch MongoDB Shell provision from map-based struct to string, becau… 

    …se it allows for more control over the order in which the arguments are provisioned
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d0b7f37 View commit details
    Browse the repository at this point in the history

  7. Test to verify the provisioned arguments and expected command line ar… 

    …guments but it's not working just yet due to slice range issues
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    311263a View commit details
    Browse the repository at this point in the history

  8. Remove previously introduced but currently unused generic provisioner… 

    …s: arguments provisioner and chained provisioner
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    dca6e83 View commit details
    Browse the repository at this point in the history

  9. Require authentication for just mongosh command

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a31fa56 View commit details
    Browse the repository at this point in the history

  10. Mark password field as mandatory for now. It's not technically mandat… 

    …ory because the default setup of MongoDB is password-less, but the bulk of MongoDB deployments have a password set. And, having a password required helps prevent field-less 1Password item creation, thus offering a better onboarding UX
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    a4b3436 View commit details
    Browse the repository at this point in the history

  11. Remove Importer at the CredentialUsage-level because in the current i… 

    …mplementation, it does not differ from the Default Importer, which is nil
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c4244cb View commit details
    Browse the repository at this point in the history

  12. Rename mongodbshell plugin to mongodb

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    33c12bf View commit details
    Browse the repository at this point in the history

  13. Refactor argument provisioning logic to avoid string splitting

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    12d0967 View commit details
    Browse the repository at this point in the history

  14. Skip 1Password authentication when an user enters custom host, port, … 

    …username or password
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c540690 View commit details
    Browse the repository at this point in the history

  15. Look for ConnectionString field in a 1Password item, and if it exists… 

    …, use that instead of host and port fields
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    eecbebe View commit details
    Browse the repository at this point in the history

  16. Fix provisoner test

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ae5c946 View commit details
    Browse the repository at this point in the history

  17. Safeguard in the arguments injection code to prevent out of bounds er… 

    …rors, but this is not necessarily a concern in mongosh because we always provision at index 1 and mongosh is the minimum required command
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    5ab2c6a View commit details
    Browse the repository at this point in the history

  18. Set default provisioner to NoOp for now for validation checks to pass… 

    …. When we resume Terraform compatibility work in the future, we'd update the default provisioner to match the environment variables used in the majority of the mongodb Terraform providers
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d92c6b9 View commit details
    Browse the repository at this point in the history

  19. Switch default importer to noop

    @arunsathiya
    Arun authored and arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    0999979 View commit details
    Browse the repository at this point in the history

  20. Don't skip auth for certain flags, rather use them in conjunction wit… 

    …h 1Password-stored secrets to provision
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    513bd6e View commit details
    Browse the repository at this point in the history

  21. Support both standard connection string format and SRV connection format

    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    faaedf3 View commit details
    Browse the repository at this point in the history

  22. Fix arguments for host and port. These arguments are used when connec… 

    …tion string is not present in the 1Password item
    @arunsathiya
    arunsathiya committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    08e27c6 View commit details
    Browse the repository at this point in the history