-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
civo plugin added #286
civo plugin added #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @itsCheithanya, thank you for your contribution! 🙌🏼
I haven't taken a proper look at the proposed changes yet, but can move forward with a couple of things:
- Could you upload a sample config file? Here's an example from readme shell plugin. Once that's done, you can remove the sample config from the credential function.
- Could you address/remove all
TODO
comments like this one? - Could you also complete the importer test?
I'll mark this PR as in progress, and don't hesitate to ping me if you have any questions.
Heyy @arunsathiya I have done all the required changes and additions |
Also @itsCheithanya, I just noticed that your commits aren't signed. Could you set up commit signing and rebase all previous commits before we move further along? This comment can help, and more specifically, commit signing is easy to set up with 1Password. |
okay @arunsathiya should I rebase civo branch to main branch by typing |
Glad commit signing is set up! Regarding rebase the commits to be verified, could you run |
Hmm, @itsCheithanya, I am not too sure what's happening here but going by the number of commits that show this error, I suspect that the rebase occurred for commits besides your original ones as well? I don't know for sure; it's my first time using interactive rebasing. At this point, a new PR would be ideal! Feel free to ping me on that PR when it's up. |
@arunsathiya I've created on more PR on this |
Closing this PR in favor of the other one: |
Overview
Type of change
Related Issue(s)
How To Test
Install Civo CLI
https://www.civo.com/docs/overview/civo-cli
Test the plugin by running
op plugin init civo
civo region ls
Changelog