Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commit signing PR comment on fork PRs #307

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

florisvdg
Copy link
Member

@florisvdg florisvdg commented Jun 22, 2023

Overview

Follow-up to #289

Currently, the commit signing check on PRs doesn't show the PR comment if the PR author is external.

This is because the passed in GITHUB_TOKEN does not have write access to the PR.

For more info about the problem and the solution, see this write-up on the actions/labeler repo which has the same problem.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

How To Test

  1. Create shell-plugins fork on personal namespace
  2. Create a PR from a different account that does not have write access to the fork

Changelog

N/A

@florisvdg florisvdg requested a review from jpcoenen June 22, 2023 14:24
@florisvdg
Copy link
Member Author

florisvdg commented Jun 22, 2023

For some reason the workflow didn't run on this PR. Will have to do more investigation around the pull_request_target functionality.

@AndyTitu AndyTitu merged commit a39d64a into main Jun 29, 2023
4 checks passed
@AndyTitu AndyTitu deleted the fork-pr-commit-signing-comment branch June 29, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants