Render CLI Shell plugin #308

smyja · 2023-06-22T17:18:34Z

Overview

Type of change

Created a new plugin
Improved contributor utilities or experience

How To Test

Changelog

hculea

Thank you for your contribution!

I left some guidance, I'd love if you could address the remaining TODOs, before the next round of review. 😄

plugins/render/api_key.go

plugins/render/api_key_test.go

hculea

Thanks for addressing my suggestions!

I see that this submission currently contains two plugins: deta and render. Let's move the former in a separate PR.

plugins/render/api_key.go

techcraver · 2023-06-26T14:46:04Z

Hello! Is this a submission for the 1Password Hackathon with Hashnode? If so, when you're ready, please be sure you write a blog post on Hashnode to make your submission official. Full instructions are on the Hackathon page.

smyja · 2023-06-26T16:28:16Z

Hello! Is this a submission for the 1Password Hackathon with Hashnode? If so, when you're ready, please be sure you write a blog post on Hashnode to make your submission official. Full instructions are on the Hackathon page.

It's an entry, i want to write one article for all my contributions.

hculea

Moving in the right direction! Love it 🚀

plugins/render/api_key.go

plugins/render/api_key_test.go

plugins/render/plugin.go

hculea

We're almost there! 🚀

plugins/render/render.go

plugins/render/api_key_test.go

plugins/render/api_key.go

plugins/render/api_key_test.go

hculea

Have a look over the test suite and lint - I left one indication over how to start. 😄

plugins/render/api_key_test.go

hculea · 2023-06-29T11:39:35Z

Also, could you please sign your commits? The trace of the Github Action ("Check signed commits in PR") should provide a good indication of how to do so.

hculea · 2023-06-29T11:53:43Z

You can validate your tests to pass by running make test locally, before pushing your code 😄 It's faster than waiting for the pipelines to pass/fail!

Do let me know if you need any help to make the pipelines ✅ .

Signed-off-by: Smyja <akposlive59@gmail.com>

smyja · 2023-06-29T12:08:17Z

Also, could you please sign your commits? The trace of the Github Action ("Check signed commits in PR") should provide a good indication of how to do so.

I have signed the commits.

hculea

Code looks great!

I did NOT functionally test this, as I'm having some trouble currently with my local builds, so I'd love if @arunsathiya or @AndyTitu could take a look here.

Approving for the code.

hculea · 2023-06-30T11:07:16Z

plugins/render/api_key_test.go

+ Files: map[string]sdk.OutputFile{
+ "~/.render/config.yaml": {
+ Contents: []byte(plugintest.LoadFixture(t, "config.yaml") + "\n"),
+ },


Let's add a newline directly to the file, shall we?

smyja · 2023-06-30T11:50:37Z

Code looks great!

I did NOT functionally test this, as I'm having some trouble currently with my local builds, so I'd love if @arunsathiya or @AndyTitu could take a look here.

Approving for the code.

great, can you change the label status?

hculea · 2023-07-05T07:37:18Z

@smyja I'll leave it like this, until we get a functional testing too.

Then we can proceed to the security review, when I will be changing the label. 😄

AndyTitu · 2023-07-05T11:36:19Z

@smyja could you possible provide a video/image in which you test that this plugin works as expected for the render cli?

The steps to test are:

checkout this branch
run make render/build
run op plugin init render given that you have op cli installed
run a render command that requires auth

smyja marked this pull request as ready for review June 24, 2023 07:18

hculea requested changes Jun 24, 2023

View reviewed changes

AndyTitu added the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jun 26, 2023

hculea requested changes Jun 26, 2023

View reviewed changes

plugins/render/api_key.go Outdated Show resolved Hide resolved

arunsathiya added the hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th label Jun 26, 2023

arunsathiya assigned smyja Jun 27, 2023

smyja requested a review from hculea June 28, 2023 05:35

hculea reviewed Jun 28, 2023

View reviewed changes

smyja requested a review from hculea June 28, 2023 10:30

hculea reviewed Jun 29, 2023

View reviewed changes

smyja requested a review from hculea June 29, 2023 09:39

hculea reviewed Jun 29, 2023

View reviewed changes

plugins/render/api_key_test.go Show resolved Hide resolved

hculea reviewed Jun 29, 2023

View reviewed changes

plugins/render/api_key_test.go Show resolved Hide resolved

smyja added 13 commits June 29, 2023 13:05

render initial setup

cabd320

Signed-off-by: Smyja <akposlive59@gmail.com>

updated file struct

3671af3

Signed-off-by: Smyja <akposlive59@gmail.com>

update

2d57bbf

Signed-off-by: Smyja <akposlive59@gmail.com>

fixed management url

1ddd1f5

Signed-off-by: Smyja <akposlive59@gmail.com>

updated test file

fe27df5

Signed-off-by: Smyja <akposlive59@gmail.com>

Deta.space initital setup

bf892a9

Signed-off-by: Smyja <akposlive59@gmail.com>

update

5c8c30b

Signed-off-by: Smyja <akposlive59@gmail.com>

update

71ae6a2

Signed-off-by: Smyja <akposlive59@gmail.com>

removed comment

f2b5c6e

Signed-off-by: Smyja <akposlive59@gmail.com>

removed todos

20942cc

Signed-off-by: Smyja <akposlive59@gmail.com>

removed apikey importer test

1ef074e

Signed-off-by: Smyja <akposlive59@gmail.com>

changed config file path

e087922

Signed-off-by: Smyja <akposlive59@gmail.com>

removed todo

1acb973

Signed-off-by: Smyja <akposlive59@gmail.com>

smyja added 12 commits June 29, 2023 13:05

fixed formatting

787c9a4

Signed-off-by: Smyja <akposlive59@gmail.com>

removed default

3538e22

Signed-off-by: Smyja <akposlive59@gmail.com>

added provision input

ece89c0

Signed-off-by: Smyja <akposlive59@gmail.com>

removed todo

3baab32

Signed-off-by: Smyja <akposlive59@gmail.com>

removed importer.TryAll

c6648b9

Signed-off-by: Smyja <akposlive59@gmail.com>

removed configpath function

e01358f

Signed-off-by: Smyja <akposlive59@gmail.com>

Api key importer test

56aa1f3

Signed-off-by: Smyja <akposlive59@gmail.com>

updated needsauth

c4374ad

Signed-off-by: Smyja <akposlive59@gmail.com>

config.yml

546358b

Signed-off-by: Smyja <akposlive59@gmail.com>

update

afef4aa

Signed-off-by: Smyja <akposlive59@gmail.com>

updated test

a695a2e

Signed-off-by: Smyja <akposlive59@gmail.com>

formatted files

8bb7913

Signed-off-by: Smyja <akposlive59@gmail.com>

smyja force-pushed the renderr branch from 9d843d9 to 8bb7913 Compare June 29, 2023 12:06

smyja requested a review from hculea June 29, 2023 12:26

smyja added 2 commits June 29, 2023 21:44

fixed test

57ffcb6

fixed lint

237c794

hculea approved these changes Jun 30, 2023

View reviewed changes

hculea requested a review from AndyTitu July 5, 2023 07:36

smyja closed this Jul 13, 2023

arunsathiya removed the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Aug 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render CLI Shell plugin #308

Render CLI Shell plugin #308

smyja commented Jun 22, 2023 •

edited

Loading

hculea left a comment

hculea left a comment

techcraver commented Jun 26, 2023

smyja commented Jun 26, 2023

hculea left a comment

hculea left a comment

hculea left a comment

hculea commented Jun 29, 2023

hculea commented Jun 29, 2023

smyja commented Jun 29, 2023

hculea left a comment

hculea Jun 30, 2023

smyja commented Jun 30, 2023

hculea commented Jul 5, 2023

AndyTitu commented Jul 5, 2023

Render CLI Shell plugin #308

Render CLI Shell plugin #308

Conversation

smyja commented Jun 22, 2023 • edited Loading

Overview

Type of change

How To Test

Changelog

hculea left a comment

Choose a reason for hiding this comment

hculea left a comment

Choose a reason for hiding this comment

techcraver commented Jun 26, 2023

smyja commented Jun 26, 2023

hculea left a comment

Choose a reason for hiding this comment

hculea left a comment

Choose a reason for hiding this comment

hculea left a comment

Choose a reason for hiding this comment

hculea commented Jun 29, 2023

hculea commented Jun 29, 2023

smyja commented Jun 29, 2023

hculea left a comment

Choose a reason for hiding this comment

hculea Jun 30, 2023

Choose a reason for hiding this comment

smyja commented Jun 30, 2023

hculea commented Jul 5, 2023

AndyTitu commented Jul 5, 2023

smyja commented Jun 22, 2023 •

edited

Loading