-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Shell Plugin for Yugabyte #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parthiv11 This PR looks really good! I just have a couple of questions
@AndyTitu can i use both file and env provisioners? if yes then how? |
@parthiv11 You can do this by using a custom provisioner (have a look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a generally good start, thank you for your contribution @parthiv11. I noticed that YugabyteDB can be connect using ycqlsh too:
https://docs.yugabyte.com/preview/admin/
Could we build support for it too, since both of these executables seem to offer connectivity to YugabyteDB clusters. If you need examples of multi-executable shell plugins, OpenAI is a good example that supports the openai executable, and oaieval
and oaievalset
too.
I am also leaning towards building support for connectivity to the Yugabyte platform itself, which seems to be yb-admin
here:
https://docs.yugabyte.com/preview/admin/
Not sure if any of the other CLI programs are related to Yugabyte platform connectivity.
Example of us supporting both the database connectivity and platform connectivity are redis and mongoDB:
- new(redis-cli): Add support for Redis CLI with password as environment variable and command-line flags #276
- new(mongosh): Support mongosh executable for connecting to a MongoDB database #283
I understand this is all increasing the complexity, but don't hesitate to ping us if you are unclear on anything. We are happy to help.
I should also note that I have NOT functionally tested this because I am on a Apple Silicon MacBook and I am having troubles getting
@parthiv11 could you help us with some screenshots, videos or textual output of the shell plugin in action? That'd tremendously help us review faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again @parthiv11, I am wondering if we could help you with anything in getting this PR over to the finish line? Let us know and we can help you!
I will try to make it as fast as possible |
Is there any way to change permission for file generated by op cli ? |
Could you elaborate a bit more on this part? Are you referring to the temp file provisioner and what's happening at the moment? |
When I generate a .pgpass file , i need to set permission 600 to it ,for it to work How can I do it? |
Getting this warning: |
simplescreenrecorder-2023-07-15_11.44.15.mp4 |
4972659
to
b578627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end this seems to be working nicely with just the env vars. I'm approving for that functionality
Hi @parthiv11, appreciate your contribution! 🙌 The code is almost ready to be merged. All you need to do is sign your commits. You can follow the instructions below to sign your commits.
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
@SimonBarendse Done |
Overview
Added Yugabyte Shell Plugin Similar to Postgres
Related Issue(s)
How To Test
Changelog
Additional information