Added new Cohere Cli plugin #334

parthiv11 · 2023-06-29T20:32:46Z

Overview

Added cohere cli shell plugin

Type of change

Created a new plugin
Improved an existing plugin
Fixed a bug in an existing plugin
Improved contributor utilities or experience

Related Issue(s)

Resolves: #
Relates: #

How To Test

Changelog

Additional information

Check this box if this is a Hashnode Hackathon submission

arunsathiya

Hi @parthiv11, thanks for this submission. A couple of questions:

Is this still a work in progress? I see some todo.
Could you run gofmt -w . to address the linter errors?
The tests don't seem complete. Could you address them, please?

With this understanding, I'll mark this PR as in progress for now, but feel free to ping me once it's ready for a review.

arunsathiya · 2023-06-29T21:55:43Z

Also, this is a hackathon entry, yes?

techcraver · 2023-06-29T22:39:33Z

If it is a Hackathon entry - be sure to write a blog post on Hashnode tagged with 1Password and BuildWith1Password. Also, be sure to use Hashnode tags, not just "#1Password". Here's a guide. :)

parthiv11 · 2023-06-30T05:11:56Z

@arunsathiya Added tests for cohere plugins

hculea

Thanks for this contribution! Looks good, for the most part 😄

hculea · 2023-06-30T10:14:37Z

plugins/cohere/credentials.go

+			provision.Filename("config"),
+			provision.AtFixedPath("~/.command/")),


These two options, if I recall correctly, are not both taken into consideration.

I think you're looking for `provision.AtFixedPath("~/.command/config").

hculea · 2023-06-30T10:16:35Z

plugins/cohere/credentials.go

+	if value, ok := in.ItemFields[fieldname.Authtoken]; ok {
+		jwt = value
+	}


If this value is not found, let's bail and return.

plugins/cohere/credentials.go

hculea · 2023-06-30T10:19:47Z

plugins/cohere/co.go

+			needsauth.NotForHelpOrVersion(),
+			needsauth.NotWithoutArgs(),


I think there may be other commands, such as co auth login, that do not require authentication - could you have a look at what all of those may be?

this is not yet resolved

plugins/cohere/credentials.go

plugins/cohere/credentials_test.go

hculea

Almost there! 🚀 Please make sure to goimports your files, looks like the lint is complaining.

plugins/cohere/credentials.go

plugins/cohere/test-fixtures/config

hculea · 2023-07-04T08:54:22Z

Also, please have a look over the failing tests.

hculea · 2023-07-07T15:04:25Z

Hey @parthiv11 , I see there hasn't been any activity on this PR in a bit, is there anything that we can help you with?

We'd love to get this to the finish line together! 🚀

parthiv11 · 2023-07-12T16:50:02Z

co-2023-07-12_12.28.50.mp4

@hculea i think it is done

hculea

Looks great, your functional test video helps a lot! Only a few more comments related to the code.

plugins/cohere/credentials.go

AndyTitu · 2023-08-30T11:56:56Z

plugins/cohere/credentials.go

+	"context"
+
+	"encoding/json"
+	"github.com/1Password/shell-plugins/sdk"


Let's sort imports on this file to make the linter pass.

AndyTitu · 2023-08-30T11:57:44Z

plugins/cohere/credentials.go

+		out.AddCandidate(sdk.ImportCandidate{
+			Fields: map[sdk.FieldName]string{
+				fieldname.URL:       config.CurrentURL,
+				fieldname.JWT: config.Contexts[config.CurrentURL].JWT,


Let's format this code so the linter can pass

AndyTitu

code lgtm mostly. I went ahead and closed all resolved comments. There are still very few open comments which need to be resolved first, as well as some formatting required for the GitHub linter action to pass.

@parthiv11 is this something you can take a look at?

parthiv11 · 2023-09-07T11:10:46Z

@AndyTitu done

github-actions · 2023-09-29T04:24:59Z

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

github-actions · 2023-09-29T04:27:31Z

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git commit -S --amend --no-edit) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

accraw · 2023-10-18T18:27:54Z

Hi @parthiv11 !

It looks like not all the comments are resolved and the linter/tests still aren't passing. Are you able to fix those?

Thank you again for your contribution!

arunsathiya changed the title ~~👀👀Added new Cohere Cli plugin~~ Added new Cohere Cli plugin Jun 29, 2023

arunsathiya reviewed Jun 29, 2023

View reviewed changes

arunsathiya assigned parthiv11 Jun 29, 2023

arunsathiya added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jun 29, 2023

hculea reviewed Jun 30, 2023

View reviewed changes

hculea reviewed Jul 4, 2023

View reviewed changes

plugins/cohere/credentials.go Outdated Show resolved Hide resolved

plugins/cohere/test-fixtures/config Outdated Show resolved Hide resolved

hculea requested review from hculea and arunsathiya and removed request for hculea and arunsathiya July 4, 2023 08:54

hculea reviewed Jul 17, 2023

View reviewed changes

plugins/cohere/credentials.go Outdated Show resolved Hide resolved

plugins/cohere/credentials.go Outdated Show resolved Hide resolved

plugins/cohere/credentials.go Outdated Show resolved Hide resolved

hculea self-requested a review July 17, 2023 10:41

arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 24, 2023

parthiv11 force-pushed the cohere branch 2 times, most recently from 9bb9ebf to a991242 Compare July 30, 2023 17:47

AndyTitu reviewed Aug 30, 2023

View reviewed changes

AndyTitu added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Aug 30, 2023

parthiv11 force-pushed the cohere branch from 7a545b1 to ee2c3fc Compare September 29, 2023 04:27

parthiv11 added 2 commits September 29, 2023 09:59

Added new Cohere Cli plugin

23531fb

Recommited with sign

0bcab72

parthiv11 force-pushed the cohere branch from ee2c3fc to 0bcab72 Compare September 29, 2023 04:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new Cohere Cli plugin #334

Added new Cohere Cli plugin #334

parthiv11 commented Jun 29, 2023 •

edited

Loading

arunsathiya left a comment

arunsathiya commented Jun 29, 2023

techcraver commented Jun 29, 2023 •

edited

Loading

parthiv11 commented Jun 30, 2023

hculea left a comment

hculea Jun 30, 2023

hculea Jun 30, 2023

hculea Jun 30, 2023

AndyTitu Aug 30, 2023

hculea left a comment

hculea commented Jul 4, 2023

hculea commented Jul 7, 2023

parthiv11 commented Jul 12, 2023

hculea left a comment

AndyTitu Aug 30, 2023

AndyTitu Aug 30, 2023

AndyTitu left a comment

parthiv11 commented Sep 7, 2023

github-actions bot commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

accraw commented Oct 18, 2023

		provision.Filename("config"),
		provision.AtFixedPath("~/.command/")),

Added new Cohere Cli plugin #334

Are you sure you want to change the base?

Added new Cohere Cli plugin #334

Conversation

parthiv11 commented Jun 29, 2023 • edited Loading

Overview

Type of change

Related Issue(s)

How To Test

Changelog

Additional information

arunsathiya left a comment

Choose a reason for hiding this comment

arunsathiya commented Jun 29, 2023

techcraver commented Jun 29, 2023 • edited Loading

parthiv11 commented Jun 30, 2023

hculea left a comment

Choose a reason for hiding this comment

hculea Jun 30, 2023

Choose a reason for hiding this comment

hculea Jun 30, 2023

Choose a reason for hiding this comment

hculea Jun 30, 2023

Choose a reason for hiding this comment

AndyTitu Aug 30, 2023

Choose a reason for hiding this comment

hculea left a comment

Choose a reason for hiding this comment

hculea commented Jul 4, 2023

hculea commented Jul 7, 2023

parthiv11 commented Jul 12, 2023

hculea left a comment

Choose a reason for hiding this comment

AndyTitu Aug 30, 2023

Choose a reason for hiding this comment

AndyTitu Aug 30, 2023

Choose a reason for hiding this comment

AndyTitu left a comment

Choose a reason for hiding this comment

parthiv11 commented Sep 7, 2023

github-actions bot commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

accraw commented Oct 18, 2023

parthiv11 commented Jun 29, 2023 •

edited

Loading

techcraver commented Jun 29, 2023 •

edited

Loading