Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kaggle CLI #341

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Add support for Kaggle CLI #341

merged 4 commits into from
Jul 25, 2023

Conversation

rajapri28613
Copy link
Contributor

Overview

Add support for Kaggle CLI. Kaggle CLI supports environment variables KAGGLE_KEY and KAGGLE_USERNAME

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install Kaggle CLI and set up shell plugin.
  • Run op plugin init kaggle to configure username and Kaggle API Key.
  • Future queries should use these credentials.

Changelog

Add support for Kaggle.

Additional information

@rajapri28613
Copy link
Contributor Author

Corresponding blog post: https://rajapri28613.hashnode.dev/1password-shell-plugin-for-kaggle

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jul 3, 2023
@hculea hculea requested a review from AndyTitu July 5, 2023 07:31
arunsathiya
arunsathiya reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start, thanks @rajapri28613! Only one comment about adding support for config file importer.

plugins/kaggle/api_token_test.go Outdated Show resolved Hide resolved
plugins/kaggle/api_token.go Show resolved Hide resolved
@arunsathiya arunsathiya self-requested a review July 12, 2023 11:57
@accraw accraw added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 14, 2023
@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 19, 2023
arunsathiya
arunsathiya approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config file importer works and code changes look good to me. Thanks for your contribution, @rajapri28613!

@accraw accraw added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 24, 2023
SimonBarendse
SimonBarendse approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your contribution!

I have left a tiny suggestion for your consideration.

plugins/kaggle/api_token.go Outdated Show resolved Hide resolved
@arunsathiya @SimonBarendse
Update username field as it is not a secret
07f6710 
Co-authored-by: Simon Barendse <SimonBarendse@users.noreply.github.com>
@arunsathiya arunsathiya merged commit 0b46a42 into 1Password:main Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBarendse SimonBarendse SimonBarendse approved these changes

@arunsathiya arunsathiya arunsathiya approved these changes

@accraw accraw accraw approved these changes

@AndyTitu AndyTitu Awaiting requested review from AndyTitu

Assignees

@rajapri28613 rajapri28613

Labels
hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajapri28613 @SimonBarendse @arunsathiya @accraw