Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Axiom CLI #342

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Add support for Axiom CLI #342

merged 4 commits into from
Sep 21, 2023

Conversation

rajapri28613
Copy link
Contributor

Overview

Add support for Axiom CLI. The CLI has support for environment variable AXIOM_TOKEN which can be used for authentication.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install Axiom CLI and set up shell plugin.
  • Run op plugin init axiom
  • Future queries should set AXIOM_TOKEN and use it for authentication.

Changelog

Add support for Axiom CLI.

Additional information

@rajapri28613
Copy link
Contributor Author

Corresponding blog post: https://rajapri28613.hashnode.dev/1password-shell-plugin-for-axiom

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jul 3, 2023
hculea
hculea reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@hculea hculea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! A few comments and questions.

plugins/axiom/axiom.go Outdated Show resolved Hide resolved
plugins/axiom/personal_access_token.go Outdated Show resolved Hide resolved
plugins/axiom/personal_access_token.go Outdated Show resolved Hide resolved
@hculea hculea self-requested a review July 5, 2023 07:30
@hculea
Copy link
Member

hculea commented Jul 7, 2023

Hey @rajapri28613 , I see there hasn't been any activity on this PR in a bit, is there anything that we can help you with?

We'd love to get this to the finish line together! 🚀

@accraw accraw added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 14, 2023
@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Jul 19, 2023
arunsathiya
arunsathiya approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test. ✅

plugins/axiom/personal_access_token.go Outdated Show resolved Hide resolved
@accraw accraw added in-progress this PR is being worked on/comments are in the process of being addressed by the contributor and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 24, 2023
@arunsathiya arunsathiya requested a review from hculea July 26, 2023 01:48
hculea
hculea approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@hculea hculea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I haven't functionally reviewed yet.

Would love a sec review from @SimonBarendse first!

@hculea hculea added waiting-on-sec-review and removed in-progress this PR is being worked on/comments are in the process of being addressed by the contributor labels Sep 19, 2023
@SimonBarendse SimonBarendse merged commit 54ec59d into 1Password:main Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hculea hculea hculea approved these changes

@arunsathiya arunsathiya arunsathiya approved these changes

@SimonBarendse SimonBarendse SimonBarendse approved these changes

Assignees

@rajapri28613 rajapri28613

Labels
hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajapri28613 @hculea @SimonBarendse @arunsathiya @accraw