Add support for Contentful CLI #343
Conversation
|
I have some problems with the test functions. I will fix them soon. |
|
Corresponding blog post: https://rajapri28613.hashnode.dev/1password-shell-plugin-for-contentful |
arunsathiya
added
waiting-on-reviewer
| type Config struct { | ||
| ManagementToken string `json:"managementToken"` | ||
| ActiveEnvironmentId string `json:"activeEnvironmentId"` | ||
| Host string `json:"host"` |
There was a problem hiding this comment.
Is the host something we could import from the json config file as well?
There was a problem hiding this comment.
Similar question for ActiveEnvironmentId.
| Importer: importer.TryAll( | ||
| TryContentfulConfigFile(), | ||
| )} |
There was a problem hiding this comment.
Let's use TryContentfulConfigFile() directly, no need for TryAll if there is only one importer.
| ActiveEnvironmentId: "master", | ||
| Host: "api.contentful.com", | ||
| } | ||
| contents, err := json.MarshalIndent(&config, "", " ") |
There was a problem hiding this comment.
No need for indentation, since this only produces a file meant to be consumed in a programmatic fashion. 😄
| func TestPersonalAccessTokenProvisioner(t *testing.T) { | ||
| plugintest.TestProvisioner(t, PersonalAccessToken().DefaultProvisioner, map[string]plugintest.ProvisionCase{ | ||
| "default": { | ||
| ItemFields: map[sdk.FieldName]string{ // TODO: Check if this is correct |
| needsauth.NotForHelpOrVersion(), | ||
| needsauth.NotWithoutArgs(), |
There was a problem hiding this comment.
login and logout shouldn't authenticate either, I assume.
|
Hey @rajapri28613 , I see there hasn't been any activity on this PR in a bit, is there anything that we can help you with? We'd love to get this to the finish line together! 🚀 |
accraw
added
in-progress
|
Hey @rajapri28613 , reaching out here again! Would love to see this get to the finish line. |
|
@rajapri28613 I am going to close this due to inactivity. Please do let us know if you'd like to pick this back up, would love to see this to the finish line! |
Overview
Add support for Contentful CLI. The shell plugin provisions a configuration file at
~/.contentfulrc.json. The shell plugin also imports the Contentful token from the same file at the same path, if it exists.Type of change
Related Issue(s)
How To Test
contentfulshould provision the token at~/.contentfulrc.jsonand use it for authentication.Changelog
Add support for Contentful CLI.
Additional information