Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using the
aws
plugin, if theDEFAULT_REGION
is set in the 1Password item, it will override any usage ofAWS_REGION
, which should take president normally with theaws
cli, preventing the usage of being able to connect to other regions unless you regularly change theDEFAULT_REGION
value in the1Password
each time.Type of change
Related Issue(s)
How To Test
DEFAULT_REGION
value in your 1Password item you use for theaws
pluginaws s3 ls
(or something similar)DEFAULT_REGION
AWS_REGION=different-region aws s3 ls
, using adifferent-region
then the one you have configuredIn the previous version, this would return the same value for both commands, and this should fix that.
Other options is quering for something specific by ARN that exists in only in the
DEFAULT_REGION
, and with this patch, the second command will fail, where previously it would find it.Changelog
Fix
DEFAULT_REGION
logic foraws
plugin to allow for overrides usingAWS_REGION
.