Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build argument to generate catalog files #93

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

1dustindavis
Copy link
Owner

This PR adds support for a new -build argument, which can be used to generate catalog files from package-info files.

package-info files are normal yaml files in a packages-info directory at the root of the repo. An example is in the examples directory.

There is also a repo_path config option to tell gorilla where the root of your repo is on disk.

Need to create wiki pages before merging

@1dustindavis
Copy link
Owner Author

Recently realized this is currently making catalogs that include nil values. For example, it will add values to the catalog for an uninstaller, even if one wasn't specified in the package-info file.

@danhutchings
Copy link
Contributor

Hey @1dustindavis I think I found the problem with the nil values making it in to the catalogs. There appears to be some double quotes in the wrong places in the catalog pkg. I modified lines like this:

Catalog string `yaml:"catalog",omitempty`

To instead be:

Catalog string `yaml:"catalog,omitempty"`

Once I did that, and ran a build on gorilla, the -b argument correctly procured the catalog. Try moving the double quotes on the lines with omitempty on them, and let me know what you think! Thanks!

@1dustindavis
Copy link
Owner Author

Good catch! There is definitely something weird there. I haven’t tested this out yet cause I got distracted trying to rebase, and there have been significant changes to main since this pr was created.

I plan to spend some time on this soon 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants