Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env module #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix env module #30

wants to merge 2 commits into from

Conversation

serpilliere
Copy link
Contributor

The env module seems to be broken at the moment.

  • the PR fixes the env module and adds it to the create namespace
  • the get_pam_env is done on environment initialization again (as it was in 0.7.0). If not called, it breaks sub modules environment update. For example, if you have a kerberos configuration, the module sets the KRB5CCNAME which may be used in the inherited environment.

@1wilkens
Copy link
Owner

1wilkens commented Mar 2, 2023

Hey thank you for the contribution and sorry for the late reply!
I am not sure how the env situation should be addressed best, given that get_pam_env is not available in all PAM implementations IIRC. We are currently discussing how to properly support Linux PAM and openPAM in pam-sys (PR). After that is finalized, I would take another look at this PR and the problem in general.

fx-chun added a commit to fx-chun/pam that referenced this pull request Jun 26, 2024
@fx-chun @serpilliere
env: fix module
906572a 
Squashed commit of the following:

commit 7a3af02
Author: Fabrice Desclaux <fabrice.desclaux@cea.fr>
Date:   Mon May 9 13:54:32 2022 +0200

    Set pam env in local process

commit 5564ad8
Author: Fabrice Desclaux <fabrice.desclaux@cea.fr>
Date:   Mon May 9 13:54:12 2022 +0200

    Fix env module

1wilkens#30

Co-authored-by: Fabrice Desclaux <fabrice.desclaux@cea.fr>
fx-chun added a commit to fx-chun/pam that referenced this pull request Jun 26, 2024
@fx-chun @serpilliere
env: fix module
d6a76e8 
Squashed commit of the following:

commit 7a3af02
Author: Fabrice Desclaux <fabrice.desclaux@cea.fr>
Date:   Mon May 9 13:54:32 2022 +0200

    Set pam env in local process

commit 5564ad8
Author: Fabrice Desclaux <fabrice.desclaux@cea.fr>
Date:   Mon May 9 13:54:12 2022 +0200

    Fix env module

1wilkens#30

Co-authored-by: Fabrice Desclaux <fabrice.desclaux@cea.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serpilliere @1wilkens