Compression automatique des fichiers lors d'extraction de pages #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mode de compression très haute qualité
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette MR règle l'issue #98.
Le soucis vient de PDF-lib, qui génère des fichiers anormalement gros. J'ai cherché mais je n'ai pas trouvé d'options dans PDF-lib permettant de contrôler ça. Le seul conseil que j'ai vu indiquait de faire un
.save({useObjectStreams: true}), mais je n'ai pas vu de différence sur la taille des PDF générés.Du coup, j'ai rajouté, uniquement lors de l'extraction, un appel à /compress pour compresser le fichier côté serveur, ainsi qu'un nouveau mode de compression, qui est censé être le plus haute qualité de ghostscript (si j'ai bien compris !).
Sur mes tests, je n'ai pas vu de différence de qualité entre sans/avec la compression, mais il pourrait être intéressant de rajouter une checkbox dans l'interface (mais où ?) pour activer/désactiver la compression automatique