Improve Tech Finesse Lock and add some other minor things #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(at this point if you still make a finesse error even after getting limited inputs then you have a huge skill issue)
+ Added RS name (RS.name, P.RS.name) + Added hook_spawn and hook_hold
Not-A-Normal-Robot
changed the title
|
nvm i think imma disable o rotation when RS is TRS and piece is not under overhang and landed (since transformative O-spin needs the piece to be landed and needs 3 rotations (which is only possible under an overhang in this mode)) |
|
nvm that's too hard |
|
Tested this and it works perfectly fine. It's ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs testing.