Second assignment #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oy6uns
added
good first issue
yungu0010
reviewed
Oct 14, 2022
|
|
||
| import UIKit | ||
|
|
||
| class CheckAccount: UIViewController { |
There was a problem hiding this comment.
보통 파일명과 클래스명의 끝부분에는 상속받는 클래스의 이름(UI 제외)을 붙여주는 것 같아요~! 이 뷰의 경우에는 CheckAccountViewController가 되겠네요
Comment on lines
+34
to
+39
| view.backgroundColor = .white | ||
|
|
||
| let components: [Any] = [helloLabel, acceptButton] | ||
| components.forEach{ | ||
| view.addSubview($0 as! UIView) | ||
| } |
There was a problem hiding this comment.
viewDidLoad와 같은 생명주기 함수 내에서는 보통 메소드 호출을 해주는 것이 가독성에도 더 좋고 코드가 깔끔해진다고 생각합니다❗️개인적인 의견이니 참고만 해주세요 ~!
| /// text field를 만들 때, 텍스트+밑줄을 한꺼번에 만드는 class | ||
| import UIKit | ||
|
|
||
| class KakaoCustomView: UIView { |
| // Use this method to optionally configure and attach the UIWindow `window` to the provided UIWindowScene `scene`. | ||
| // If using a storyboard, the `window` property will automatically be initialized and attached to the scene. | ||
| // This delegate does not imply the connecting scene or session are new (see `application:configurationForConnectingSceneSession` instead). | ||
| guard let _ = (scene as? UIWindowScene) else { return } |
There was a problem hiding this comment.
아래 같은 의미의 코드가 있어서 이 부분은 삭제해도 좋을 것 같습니다❗️
Comment on lines
+65
to
+66
| make.top.equalToSuperview().offset(56.adjusted) | ||
| make.leading.equalTo(self.view.safeAreaLayoutGuide.snp.leading).offset(14.adjusted) |
There was a problem hiding this comment.
make라는 반환타임을 사용하는 것과 $0 형태의 단축인자를 사용하는 것을 혼용하는 것보단 통일해 쓰면 어떨까요?👀
Comment on lines
+142
to
+156
| extension Int { | ||
| var adjusted: CGFloat { | ||
| let ratio: CGFloat = CGFloat(UIScreen.main.bounds.width) / 375 | ||
| let ratioH: CGFloat = CGFloat(UIScreen.main.bounds.height) / 812 | ||
| return ratio <= ratioH ? CGFloat(self) * ratio : CGFloat(self) * ratioH | ||
| } | ||
| } | ||
|
|
||
| extension Double { | ||
| var adjusted: CGFloat { | ||
| let ratio: CGFloat = CGFloat(UIScreen.main.bounds.width) / 375 | ||
| let ratioH: CGFloat = CGFloat(UIScreen.main.bounds.height) / 812 | ||
| return ratio <= ratioH ? CGFloat(self) * ratio : CGFloat(self) * ratioH | ||
| } | ||
| } |
There was a problem hiding this comment.
이 아이들은 따로 파일을 만들어 관리하면 좋을 것 같슴당😋
| // Use this method to optionally configure and attach the UIWindow `window` to the provided UIWindowScene `scene`. | ||
| // If using a storyboard, the `window` property will automatically be initialized and attached to the scene. | ||
| // This delegate does not imply the connecting scene or session are new (see `application:configurationForConnectingSceneSession` instead). | ||
| guard let _ = (scene as? UIWindowScene) else { return } |
There was a problem hiding this comment.
아래 같은 의미의 코드가 있어서 지워주심 될 것 같아요 ~!
6uohul
reviewed
Nov 11, 2022
| let components: [Any] = [startLabel, introLabel, emailPhoneTextField, passwordTextField, loginButton, newAccountButton] | ||
| components.forEach{ | ||
| view.addSubview($0 as! UIView) | ||
| } |
There was a problem hiding this comment.
늦게 봤네용 좋은 의견 감사합니당
chaentopia
reviewed
Nov 11, 2022
오토레이아웃 잡고 수정한다는걸,,,깜박했네요 감사합니당~!~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.