-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change layer name #963
Closed
Closed
Change layer name #963
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import Events from '../Events.js'; | ||
import { Command } from '../command.js'; | ||
import { createUniqueId } from '../entity.js'; | ||
|
||
export class EntityRenameCommand extends Command { | ||
constructor(editor, entity) { | ||
super(editor); | ||
|
||
this.type = 'entityrename'; | ||
this.name = 'Rename Entity'; | ||
this.updatable = true; // Allow updating for consecutive renames | ||
|
||
if (!entity.id) { | ||
entity.id = createUniqueId(); | ||
} | ||
this.entityId = entity.id; | ||
this.oldName = entity.getAttribute('data-layer-name') || ''; | ||
this.newName = null; // Will be set during execute | ||
} | ||
|
||
execute() { | ||
const entity = document.getElementById(this.entityId); | ||
if (!entity) return; | ||
|
||
// If newName hasn't been set (first execution), prompt for it | ||
if (this.newName === null) { | ||
const promptedName = prompt('Enter new name for entity', this.oldName); | ||
// If user cancels or enters empty name, abort | ||
if (!promptedName) return; | ||
this.newName = promptedName; | ||
} | ||
|
||
// Apply the new name | ||
entity.setAttribute('data-layer-name', this.newName); | ||
Events.emit('entityrenamed', { | ||
entity, | ||
oldName: this.oldName, | ||
newName: this.newName | ||
}); | ||
AFRAME.INSPECTOR.selectEntity(entity); | ||
} | ||
|
||
undo() { | ||
const entity = document.getElementById(this.entityId); | ||
if (entity) { | ||
// Restore the old name | ||
entity.setAttribute('data-layer-name', this.oldName); | ||
Events.emit('entityrenamed', { | ||
entity, | ||
oldName: this.newName, | ||
newName: this.oldName | ||
}); | ||
AFRAME.INSPECTOR.selectEntity(entity); | ||
} | ||
} | ||
|
||
update(command) { | ||
// Handle consecutive renames by updating the newName | ||
this.newName = command.newName; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be set in the constructor otherwise you can't undo/redo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo/redo works in my testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right it works, this.newName is set so it's fine afterwards