Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to new ceramic_event builder api #18

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

nathanielc
Copy link
Contributor

@nathanielc nathanielc commented May 16, 2024

The Jws from ceramic_core is copied to here as it has different needs than the one we need to build events.

For example building events must NOT have the typ set to JWK (not sure why but that is how its implemented in js-ceramic).

So in short the Jws type that lives here is for signing admin api requests and only admin api requests.

Updated the docker image we use in tests as it was failing with an older 5.1-rc version before.

@dav1do dav1do requested a review from dbcfd June 20, 2024 20:20
@dav1do dav1do marked this pull request as ready for review June 20, 2024 20:21
@dav1do dav1do changed the title wip: update to new ceramic_event builder api chore: update to new ceramic_event builder api Jun 20, 2024
@dav1do dav1do self-requested a review June 20, 2024 22:02
Copy link
Contributor

@dav1do dav1do left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but I made most of the changes.. so I'll give it a day before merging.

@dav1do dav1do merged commit a3299b3 into main Jun 21, 2024
1 check passed
@dav1do dav1do deleted the fix/update-ceramic-event-builder-api branch June 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants