feat: add network TTL #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
requested changes
Oct 10, 2023
nathanielc
force-pushed
the
feat/network_ttl
branch
from
992d2a1 to
1fd9e00
Compare
nathanielc
force-pushed
the
feat/network_ttl
branch
from
1fd9e00 to
eb6bfbb
Compare
Now that we are programmatically creating networks (see ceramic-tests) we want to make sure we are not leaving lots of unused resources around. With this feature the test driver can create networks with a generous TTL of a few hours (when we expect tests to run in a few minutes). If for some reason the test driver fails to clean up the network itself, eventually the operator will clean it up. This feature remains optional so manually created networks are not affected.
nathanielc
force-pushed
the
feat/network_ttl
branch
from
eb6bfbb to
2c2fd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are programmatically creating networks (see ceramic-tests) we want to make sure we are not leaving lots of unused resources around.
With this feature the test driver can create networks with a generous TTL of a few hours (when we expect tests to run in a few minutes). If for some reason the test driver fails to clean up the network itself, eventually the operator will clean it up.
This feature remains optional so manually created networks are not affected.