-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook urban dyn #364
Notebook urban dyn #364
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, nice showcase of the dynamic scenes capabilities!
I added some minor changes/ideas to consider
data/platforms.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove the commented position noise here to keep it a bit more readable?
Ka 0.000000 0.000000 0.000000 | ||
Kd 0.700000 0.700000 0.700000 | ||
Ks 0.700000 0.700000 0.700000 | ||
helios_classification 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set classification of building to "6" as per the ASPRS Standard?
# www.blender.org | ||
|
||
newmtl vegetation | ||
helios_classification 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vegetation should be 3, 4 or 5 (low, med, high)
# www.blender.org | ||
|
||
newmtl vegetation | ||
helios_classification 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would give class 5 here
Also, what is the license on the .jpg textures - and do we really need them? They don't make a difference for HELIOS, so I would say to remove them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job, lgtm!
data/scanners_tls.xml
Outdated
scanAngleEffectiveMax_deg = "1" | ||
scanFreqMin_Hz = "0" | ||
scanFreqMax_Hz = "0" | ||
wavelength_nm = "905" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also 903 nm according to https://www.goetting-agv.com/dateien/downloads/63-9194_Rev-G_HDL-64E_S3_Spec%20Sheet_Web.pdf
.. not that it makes a difference, but the correction for the VLP-16 made me wonder.
New notebook for demonstrating rigid motions: MLS simulation in an urban environment with two moving vehicles