-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving tree notebook #369
Moving tree notebook #369
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,1091 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe clarify that "By Loose Parts" is a functionality of Blender's meshtools package? I had to look about that on the internet.
Reply via ReviewNB
@@ -0,0 +1,1091 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last paragraph, I would change "the motion sequence is determined." by "the motion sequence will be the last one.". When saying "is determined" I was wondering if it refers to determined by the given order or determined to be the end sequence.
Reply via ReviewNB
@@ -0,0 +1,1091 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can write some times here (measured on a local computer)? They could be useful to understand the runtime difference between static and dynamic VLS. Otherwise just an "approximately x times longer" sentence could be enough as the execution times are strongly case dependent.
Reply via ReviewNB
@@ -0,0 +1,1091 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "[...] an their attributed with laspy ..." should be "[...] an their attributes with laspy ...".
Reply via ReviewNB
Another example notebook showcasing the rigid motions, this time using a tree with moving leaves