Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving tree notebook #369

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Moving tree notebook #369

merged 11 commits into from
Oct 10, 2023

Conversation

han16nah
Copy link
Contributor

Another example notebook showcasing the rigid motions, this time using a tree with moving leaves

@han16nah han16nah requested a review from lwiniwar August 25, 2023 11:44
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,1091 @@
{
Copy link
Collaborator

@albertoesmp albertoesmp Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe clarify that "By Loose Parts" is a functionality of Blender's meshtools package? I had to look about that on the internet.


Reply via ReviewNB

@@ -0,0 +1,1091 @@
{
Copy link
Collaborator

@albertoesmp albertoesmp Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last paragraph, I would change "the motion sequence is determined." by "the motion sequence will be the last one.". When saying "is determined" I was wondering if it refers to determined by the given order or determined to be the end sequence.


Reply via ReviewNB

@@ -0,0 +1,1091 @@
{
Copy link
Collaborator

@albertoesmp albertoesmp Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can write some times here (measured on a local computer)? They could be useful to understand the runtime difference between static and dynamic VLS. Otherwise just an "approximately x times longer" sentence could be enough as the execution times are strongly case dependent.


Reply via ReviewNB

@@ -0,0 +1,1091 @@
{
Copy link
Collaborator

@albertoesmp albertoesmp Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "[...] an their attributed with laspy ..." should be "[...] an their attributes with laspy ...".


Reply via ReviewNB

@han16nah han16nah merged commit 34870ad into dev Oct 10, 2023
17 checks passed
@han16nah han16nah deleted the mov_tree_nb branch October 10, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants