Fix compiler warnings for Clang #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimasfromLavoisier
force-pushed
the
alpha-dev
branch
from
34c6043
to
84c1316
Compare
dokempf
requested changes
Apr 25, 2024
.github/workflows/ci.yml
Outdated
| if: runner.os == 'macOS' | ||
| run: | | ||
| brew update | ||
| brew install git |
There was a problem hiding this comment.
What is the reason for this? I don't think it is required?
| @@ -45,12 +49,15 @@ jobs: | |||
| activate-environment: helios-dev | |||
| environment-file: environment-dev.yml | |||
| python-version: ${{ matrix.python }} | |||
| miniconda-version: "latest" | |||
src/pybinds/PyBeamDeflectorWrapper.h
Outdated
| @@ -78,23 +78,23 @@ class PyBeamDeflectorWrapper{ | |||
| inline std::string getOpticsType() const {return getOpticsType(0);} | |||
| inline std::string getOpticsType(size_t const idx) const { | |||
| try{ | |||
| dynamic_cast<ConicBeamDeflector &>(beamDeflector); | |||
| (void)dynamic_cast<ConicBeamDeflector &>(beamDeflector); | |||
There was a problem hiding this comment.
What is the warning related to this one?
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Install Helios | ||
| run: | | ||
| python -m pip install -v . | ||
|
|
||
| - name: Run tests | ||
| if: runner.os != 'macOS' # Skip tests on macOS for now | ||
| #because of a bug in laz files |
There was a problem hiding this comment.
Please copy my entire comment from above - it is a bit more detailed about what goes wrong (we are writing corrupted LAZ).
DimasfromLavoisier
merged commit 4ed64c4
into
3dgeo-heidelberg:alpha-dev
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added override and fixed typos for warning free compilation