Remove direct react dependency, cleanup unused dependencies, upgrade webpack-cli + sass #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes also include upgrading the package-lock.json file for the latest version of npm (7.24.0)
there is a direct import from prop-types in ReactCodeInput.js
prevents this error after upgrade to storybook v5: webpack/webpack#8082
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 2 2
Lines 145 145
Branches 41 41
=======================================
Hits 140 140
Misses 5 5
Continue to review full report at Codecov.
|
This was referenced Oct 14, 2021
dobesv
reviewed
Jul 11, 2022
Comment on lines
-70
to
-71
| "react": "^16.3.2", | ||
| "react-dom": "^16.3.2" |
There was a problem hiding this comment.
These should still be put into devDependencies to show they are directly used by this package, relying on other packages to install your dependencies isn't as good and when using Yarn PnP won't even work as you must declare explicitly all dependencies you import in your package.
|
Bump! Is there any chance that this will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the direct react and react-dom dependencies cause react and react-dom 16 to be installed when adding
react-code-inputto a react v17.x application, so i removed the direct react and react-dom dependencies, keeping them only as peer dependencies (fixes #75). storybook still takes care of installing them so thatnpm startworks, andyarn buildstill works. in addition:prop-typesto peer dependencies (there is a direct import fromprop-typesin ReactCodeInput.js)webpack-cli(prepares for the possibility of upgrading storybook, which otherwise leads to Error when trying to build bundle after upgrading to4.20.0webpack/webpack#8082)sass