This repository has been archived by the owner on Dec 19, 2023. It is now read-only.
Site wide stored cross site scripting via Client Side Template Injection #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📊 Metadata *
Bounty URL: https://huntr.dev/bounties/5-other-monicahq/monica/
⚙️ Description *
I fixed a client side template injection (csti) vulnerability in monica that was due to vue.js and blade’s
{{ code }}
syntax. I simply filtered out the curly brackets ( {{ and }} ).💻 Technical Description *
I added a simple regex
preg_replace()
to get rid of those pesky double curly brackets using/{{|}}/
. This makes use of the ‘alternation’ ( | ) operator to find any of the substrings ‘{{‘ or ‘}}’ and replace them with ‘’ (nothing).🐛 Proof of Concept (PoC) *
Click ‘add someone’, then set their name to the javascript payload surrounded by double curly brackets e.g.
{{ alert(‘xss’) }}
and click ‘add’. This will cause the code to run.🔥 Proof of Fix (PoF) *
Add another person with the same name, the code doesn’t run.
note: this change doesn’t affect already created ‘people’.
👍 User Acceptance Testing (UAT)
N/A