Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling specific chat services / protocols #543

Closed
wants to merge 1 commit into from

Conversation

hloeung
Copy link
Collaborator

@hloeung hloeung commented Sep 7, 2023

Certain things like Slack runs various things on startup and connect even though a user may not use it (e.g. myself).

This adds support for disabling specific chat services / protocols completely.

Certain things like Slack runs various things on startup and connect
even though a user may not use it (e.g. myself).

This adds support for disabling specific chat services / protocols
completely.
@hloeung hloeung marked this pull request as ready for review September 7, 2023 23:29
@hloeung hloeung requested a review from 42wim September 8, 2023 08:47
@42wim
Copy link
Owner

42wim commented Sep 9, 2023

Hm what exactly is the issue ? They shouldn't do anything unless you specifically message slack or mastodon for a login.
So I don't really see the use-case here, unless I'm missing something.

@hloeung hloeung marked this pull request as draft September 10, 2023 02:06
@hloeung
Copy link
Collaborator Author

hloeung commented Sep 10, 2023

I found out what the issue was. If my IRC client passes through a password, then it'll initiate the slack bits. e.g:

[2023-09-10T16:01:34+10:00]  INFO matterircd: Running version 0.27.2-dev
[2023-09-10T16:01:34+10:00]  INFO matterircd: WARNING: THIS IS A DEVELOPMENT VERSION. Things may break.
[2023-09-10T16:01:34+10:00]  INFO matterircd: Listening on 127.0.0.1:6669
[2023-09-10T16:01:44+10:00]  INFO matterircd: New connection: 127.0.0.1:52540
slack-go/slack2023/09/10 16:01:44 websocket_managed_conn.go:205: Connecting to RTM
slack-go/slack2023/09/10 16:01:44 rtm.go:71: Using URL:
slack-go/slack2023/09/10 16:01:44 websocket_managed_conn.go:209: Failed to start or connect to RTM: invalid_auth
slack-go/slack2023/09/10 16:01:44 websocket_managed_conn.go:147: invalid auth when connecting with RTM: invalid_auth
slack-go/slack2023/09/10 16:01:44 websocket_managed_conn.go:69: Failed to connect with RTM on try 0: invalid_auth

This is my irssi config FWIW:

  {
    address = "localhost";
    chatnet = "Mattermost";
    port = "6669";
    password = "XXXX";
    use_ssl = "no";
    starttls = "no";
    no_cap = "yes";
  },

Commenting out the "password = ..." line above fixes this. So yeah, local configuration error, closing this off.

@hloeung hloeung closed this Sep 10, 2023
@hloeung hloeung deleted the allow-disable branch September 10, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants