support local connections without ssh #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why can we not just mount the local ssh settings into the Dev Container? Has this been tested for upstarts without DevContainers being involved? |
benmaidel
requested changes
Jul 16, 2024
robmuxinator/robmuxinator.py
Outdated
| @@ -132,6 +133,9 @@ def __init__(self, user, hostname, port=DEFAULT_PORT): | |||
| # check if user has sudo privileges | |||
| self._sudo_user = True if os.getuid() == 0 else False | |||
|
|
|||
| self._use_local_connection = self._hostname == "localhost" \ | |||
There was a problem hiding this comment.
localhost could also be 127.0.0.1
|
I considered @benmaidel's comment plus some additional pylint fixes and also bumped the robmuxinator version @cmaneth can you make me collaborator, so I can push my changes to your branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for https://github.com/4am-robotics/amr_deployment/pull/48