Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation error report update #176

Merged
merged 2 commits into from
Jun 3, 2024
Merged

validation error report update #176

merged 2 commits into from
Jun 3, 2024

Conversation

aschroed
Copy link
Member

Seeing reporting of 'Unable to resolve link' errors for items that are included in the workbook that should be ignored as errors on dry run as they will be posted before the item that is linking to it when actually posting.

I inadvertently introduced this for cases where the alias was provided as the 'error_id' parameter to the error_report function when attempting to fix the bug that prevented reporting of other types of validation errors in an informative way.

The issue was due to the error responses including the item type concatenated with the alias string, and now because of removal of the clause to use the alias if provided as a parameter in order to make the error reporting more informative there needs to be additional parsing to get the alias bit and just that with no extra text.
{'location': 'body', 'name': 'Schema: ', 'description': 'Unable to resolve link: /Biosample/test-old-dekker-lab:Biosample_hap1cellsT2_HAP1-XH-G1-SD20221126-ED20221203'}
Is an example of the returned response and the change here will remove the /Biosample/ part so only the alias remains to compare with other aliases in the workbook.

@coveralls
Copy link

coveralls commented May 31, 2024

Coverage Status

coverage: 83.187%. remained the same
when pulling a8c636c on ajs_validation_bug_fix
into 0a9596f on master.

@coveralls
Copy link

Coverage Status

coverage: 83.187%. remained the same
when pulling eabcf77 on ajs_validation_bug_fix
into 0a9596f on master.

@aschroed aschroed merged commit 1897045 into master Jun 3, 2024
4 checks passed
@aschroed aschroed deleted the ajs_validation_bug_fix branch June 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants