Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajs fix ecred bug #178

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Ajs fix ecred bug #178

merged 2 commits into from
Aug 19, 2024

Conversation

aschroed
Copy link
Member

Make request to get_upload_creds to use datastore=database to avoid timing issues that was preventing multiple extra_file uploads.

@coveralls
Copy link

Coverage Status

coverage: 83.173% (-0.01%) from 83.187%
when pulling cad104b on ajs_fix_ecred_bug
into d80a7db on master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 83.173% (-0.01%) from 83.187%
when pulling cad104b on ajs_fix_ecred_bug
into d80a7db on master.

Copy link
Member

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if this fix alone is enough, it may be worth scanning the file for other instances and converting it to database calls elsewhere as well

Copy link

@RahiNav RahiNav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using dummy files - 2 fastq, 2 compressed tsv with index files. Uploaded at the same time. All were successfully uploaded.

@aschroed aschroed merged commit 1799871 into master Aug 19, 2024
4 checks passed
@aschroed aschroed deleted the ajs_fix_ecred_bug branch August 19, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants