Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrapping bundle init #1

Merged
merged 14 commits into from
Jul 25, 2024
Merged

Bootstrapping bundle init #1

merged 14 commits into from
Jul 25, 2024
+814 −79

Conversation

PrimalPimmy
Copy link
Member

No description provided.

@PrimalPimmy
Bootstrapping bundle init
de5e8c7 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
minor fix
efe3e1c 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@shivaccuknox
Copy link

Please attach the call flow diagram to the PR so that reviewers will have some context

@PrimalPimmy
Cluster reconciler
a1054da 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Cluster reconciler
d14b9d7 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
sending bundle to remote cluster
e4f6ee9 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Test
feb9279 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Spire auth inside reconciler
79c9f30 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
shivaccuknox
shivaccuknox reviewed Jul 1, 2024
View reviewed changes
controllers/pkg/reconcilers/spire-bootstrap/reconciler.go Outdated

// // Example: Update the status if necessary

socketPath := "unix:///spiffe-workload-api/agent.sock"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a config map for socket path, Vault IP address in nephio-system ns.

@PrimalPimmy PrimalPimmy force-pushed the spire branch 2 times, most recently from ca000a7 to 79c9f30 Compare July 4, 2024 02:46
@PrimalPimmy
Vault authentication and fetching kubeconfig
34a4957 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Copy link
Member Author

Ref: https://github.com/5GSEC/SIG-Security/issues/9

@PrimalPimmy
Some testing
687409d 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Copy link
Member Author

TODOs:
Create configmap/env variables for things like Vault IP, Spire unix domain socket, etc

@PrimalPimmy
Mid testing
dd2e75a 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing-2

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing-2

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing-2

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing-3

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing-3

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Mid testing-3

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Refactoring
e1fe02d 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Kubeconfig test

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Removed found

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

log testing

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

log testing

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

log testing

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Getting svid
b075464 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Getting svid-2

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Getting svid-2

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Getting svid-3

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Getting svid-4

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Getting svid-5

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Getting svid-6

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Vault addr and patch configmap
7f7d286 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Vault addr and patch configmap

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
@PrimalPimmy
Restricted Kubeconfig
0f84207 
Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

configmap perms

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

server addr

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Struct to yaml

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Struct to yaml

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>

Reverting changes

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
shivaccuknox
shivaccuknox approved these changes Jul 25, 2024
View reviewed changes
Copy link

@shivaccuknox shivaccuknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes need to this commit. Will raise separate issues for tracking them

@shivaccuknox shivaccuknox merged commit 42bf15c into main Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivaccuknox shivaccuknox shivaccuknox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrimalPimmy @shivaccuknox