Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modifying the trigger for the mutateexisting policy to the Nimbus policy #216

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

shivaccuknox
Copy link
Contributor

Modifying the trigger for the mutateexisting policy to a Nimbus policy. Since it is guaranteed
that a nimbus policy will be created before a mutateexisting policy, we can ensure that the mutateexisting
policy will always be triggered.

Description

Fixes #215

Does this PR introduce a breaking change?
No

Checklist

  • [*] PR title follows the <type>: <description> convention
  • [*] I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • [*] I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • [*] I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

I have tested in my local setup (make run of the nimbus-kyverno adapter), and it works.

Mention if this PR is part of any design or a continuation of previous PRs

   Policy. Since it is guaranteed that a nimbus policy will be created
   before a mutateexisting policy, we can ensure that the mutateexisting
   policy will always be triggered.
@shivaccuknox shivaccuknox requested a review from VedRatan July 6, 2024 14:31
@shivaccuknox shivaccuknox marked this pull request as ready for review July 6, 2024 14:46
@VedRatan VedRatan merged commit 1195c7d into 5GSEC:main Jul 6, 2024
22 checks passed
@shivaccuknox shivaccuknox deleted the shiv/coco-fix branch July 8, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nimbus-kyverno: kyverno coco policy fails to patch an existing deployment
2 participants