Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a cleanup script that can delete all resources (running the… #30

Closed
wants to merge 1 commit into from

Conversation

seungsoo-lee
Copy link
Collaborator

… script will remove all resources at once)

fix:: Resolve an issue with deleting SIBs

  • Fixed code so that when deleting a SIB, logs are properly generated and the created nimberpolicy is also deleted.

�style(cleanup): Add license

Move script file

Deleted files

Description

Fixes # (issue)

Does this PR introduce a breaking change?

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat anurag-rajawat mentioned this pull request Jan 9, 2024
7 tasks
… script will remove all resources at once)

fix:: Resolve an issue with deleting SIBs
- Fixed code so that when deleting a SIB, logs are properly generated and the created nimberpolicy is also deleted.

�style(cleanup): Add  license

Move script file

Deleted files
@seungsoo-lee seungsoo-lee deleted the first branch January 10, 2024 01:12
@seungsoo-lee seungsoo-lee restored the first branch January 10, 2024 01:12
@seungsoo-lee seungsoo-lee deleted the first branch January 10, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants