Allow to load configuration from globals #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
# Changelog v0.2.0 (12.11.2024) Dieser Changelog deckt die Änderungen zwischen folgenden Versionen ab: [v0.1.0 und v0.2.0](v0.1.0...v0.2.0). Weitere Hinweise befinden sich im Changelog der vorherigen Version: [v0.1.0](https://github.com/5minds/node-red-contrib-processcube-elasticsearch/releases/tag/v0.1.0). ## Merged Pull Requests - none [skip ci]
luisthieme
requested changes
Nov 14, 2024
elastic-search-logger.js
Outdated
Comment on lines
13
to
17
| let url = ""; | ||
| if(config.urlType == "global"){ | ||
| url = this.context().global.get(config.url); | ||
| } else { | ||
| url = config.url; |
There was a problem hiding this comment.
Es gibt von Node-RED eine eigene Funktion um TypedInputs auszuwerten:
Suggested change
| let url = ""; | |
| if(config.urlType == "global"){ | |
| url = this.context().global.get(config.url); | |
| } else { | |
| url = config.url; | |
| let url = RED.util.evaluateNodeProperty(n.url, n.urlType, node); |
luisthieme
approved these changes
Nov 14, 2024
|
Ah und bitte nach develop mergen und nicht main. |
|
Ist umgestellt auf develop. env und flow würde ich dich oder jemand anderen bitten, hinzuzufügen. Bei TP brauchen wir es nicht. Wahrscheinlich gibt es noch mehr Verbesserungspotential in dem Paket (z. B. das schon angesprochene Handling von Timing-Problemen, wenn z. B. das Global-Environment noch nicht die richtigen Werte zum Zeitpunkt des Konstruktordurchlaufs enthält). |
process-engine-ci
added a commit
that referenced
this pull request
Nov 15, 2024
# Changelog v0.3.0 (15.11.2024) Dieser Changelog deckt die Änderungen zwischen folgenden Versionen ab: [v0.2.0 und v0.3.0](v0.2.0...v0.3.0). Weitere Hinweise befinden sich im Changelog der vorherigen Version: [v0.2.0](https://github.com/5minds/node-red-contrib-processcube-elasticsearch/releases/tag/v0.2.0). ## Merged Pull Requests - #1 Allow to load configuration from globals (merged 14.11.2024) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to load configuration from globals.
Remove customer-specific handling of message fields.