-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ 原生 MacOs 标题栏 #215
✨ 原生 MacOs 标题栏 #215
Conversation
审核指南 by Sourcery此 PR 通过重新配置窗口构建器设置和调整侧边栏布局,实现了对 macOS 原生标题栏的支持。该实现利用 Tauri 的内置窗口自定义功能,在保持 Windows 自定义外观的同时,创造了更具原生感的 macOS 外观。 Tauri 窗口配置更改的类图classDiagram
class WebviewWindowBuilder {
+new(app, id, url)
+title(String)
+min_inner_size(Float, Float)
+inner_size(Float, Float)
+center()
+decorations(Boolean)
+transparent(Boolean)
+hidden_title(Boolean)
+title_bar_style(TitleBarStyle)
+build() Window
}
class TitleBarStyle {
<<enumeration>>
Overlay
}
WebviewWindowBuilder --> TitleBarStyle
note for WebviewWindowBuilder "修改以支持带有隐藏标题和覆盖样式的 macOS 原生标题栏"
文件级更改
可能关联的问题
提示和命令与 Sourcery 互动
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis PR implements native macOS title bar support by reconfiguring the window builder settings and adjusting the sidebar layout. The implementation uses Tauri's built-in window customization features to create a more native look and feel on macOS while maintaining a custom appearance on Windows. Class diagram for Tauri window configuration changesclassDiagram
class WebviewWindowBuilder {
+new(app, id, url)
+title(String)
+min_inner_size(Float, Float)
+inner_size(Float, Float)
+center()
+decorations(Boolean)
+transparent(Boolean)
+hidden_title(Boolean)
+title_bar_style(TitleBarStyle)
+build() Window
}
class TitleBarStyle {
<<enumeration>>
Overlay
}
WebviewWindowBuilder --> TitleBarStyle
note for WebviewWindowBuilder "Modified to support native macOS title bar with hidden title and overlay style"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @roiiiu - 我已经审查了你的更改,它们看起来很棒!
这是我在审查期间查看的内容
- 🟡 一般问题:发现1个问题
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击👍或👎,我将使用反馈来改进你的审查。
Original comment in English
Hey @roiiiu - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
📦️ 此 PR 构建的应用已经准备就绪
*从提交 b518cdb 构建 |
这个 PR 带来了什么样的更改?
这个 PR 是否存在破坏性变更?
描述
在MacOs上应用原生标题栏
动机和背景
MacOs标题栏适配问题
其他信息
检查工作