Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix napier tests #119

Merged
merged 2 commits into from
Dec 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions android/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ plugins {
}

android {
compileSdkVersion(Versions.compileSdkVersion)
buildToolsVersion(Versions.buildToolsVersion)
compileSdk = Versions.compileSdkVersion
buildToolsVersion = Versions.buildToolsVersion

defaultConfig {
namespace = "io.github.aakira.napier.sample"
minSdkVersion(Versions.minSdkVersion)
targetSdkVersion(Versions.targetSdkVersion)
minSdk = Versions.minSdkVersion
targetSdk = Versions.targetSdkVersion
versionCode = Versions.androidVersionCode
versionName = Versions.androidVersionName
}
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/kotlin/dependencies/Versions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ object Versions {
const val androidVersionCode = 1
const val androidVersionName = "1.0.0"
const val compileSdkVersion = 34
const val buildToolsVersion = "29.0.3"
const val buildToolsVersion = "34.0.0"
const val minSdkVersion = 16
const val targetSdkVersion = 34
}
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
org.gradle.jvmargs=-Xms2048M -Xmx5120M -XX:MaxPermSize=2048M
org.gradle.jvmargs=-Xms2048M -Xmx5120M

kotlin.code.style=official

Expand Down
23 changes: 12 additions & 11 deletions mpp-sample/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ version = "1.0.0"
yarn.lockFileDirectory = file("kotlin-js-store")

kotlin {
android()
androidTarget()
js {
browser()
}
Expand All @@ -25,8 +25,8 @@ kotlin {
if (ideaActive.not()) {
// intel
macosX64()
ios()
watchos()
iosX64()
watchosX64()

// apple silicon
macosArm64()
Expand Down Expand Up @@ -86,10 +86,10 @@ kotlin {
val macosX64Main by getting {
dependsOn(darwinMain)
}
val iosMain by getting {
val iosX64Main by getting {
dependsOn(darwinMain)
}
val watchosMain by getting {
val watchosX64Main by getting {
dependsOn(darwinMain)
}

Expand Down Expand Up @@ -137,15 +137,16 @@ kotlin {
}

android {
compileSdkVersion(Versions.compileSdkVersion)
buildToolsVersion(Versions.buildToolsVersion)
compileSdk = Versions.compileSdkVersion
buildToolsVersion = Versions.buildToolsVersion

defaultConfig {
namespace = "io.github.aakira.napier.mppsample"
minSdkVersion(Versions.minSdkVersion)
targetSdkVersion(Versions.targetSdkVersion)
// versionCode(Versions.androidVersionCode)
// versionName(Versions.androidVersionName)
minSdk = Versions.minSdkVersion
}

lint {
targetSdk = Versions.targetSdkVersion
}

sourceSets {
Expand Down
1,996 changes: 498 additions & 1,498 deletions mpp-sample/kotlin-js-store/yarn.lock

Large diffs are not rendered by default.

34 changes: 12 additions & 22 deletions napier/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
apply(from = rootProject.file("./gradle/publish.gradle.kts"))

kotlin {
android {
androidTarget {
publishAllLibraryVariants()
}
js(IR) {
Expand All @@ -25,9 +25,9 @@ kotlin {
if (ideaActive.not()) {
// intel
macosX64()
ios()
watchos()
tvos()
iosX64()
watchosX64()
tvosX64()

// apple silicon
macosArm64()
Expand Down Expand Up @@ -60,7 +60,6 @@ kotlin {
dependencies {
implementation(Dep.Test.common)
implementation(Dep.Test.annotation)
implementation(Dep.Coroutines.core)
}
}
val androidMain by getting {
Expand All @@ -83,24 +82,15 @@ kotlin {
implementation(Dep.Test.js)
}
}
val wasmJsMain by getting {
dependencies {
implementation(Dep.Kotlin.js)
}
}
val wasmJsTest by getting {
dependencies {
implementation(Dep.Test.js)
}
}
val wasmJsMain by getting
val wasmJsTest by getting
val jvmMain by getting {
dependencies {
implementation(Dep.Kotlin.jvm)
}
}
val jvmTest by getting {
dependencies {
implementation(Dep.Coroutines.core)
implementation(Dep.Test.jvm)
}
}
Expand All @@ -121,22 +111,22 @@ kotlin {
val macosX64Test by getting {
dependsOn(darwinTest)
}
val iosMain by getting {
val iosX64Main by getting {
dependsOn(darwinMain)
}
val iosTest by getting {
val iosX64Test by getting {
dependsOn(darwinTest)
}
val watchosMain by getting {
val watchosX64Main by getting {
dependsOn(darwinMain)
}
val watchosTest by getting {
val watchosX64Test by getting {
dependsOn(darwinTest)
}
val tvosMain by getting {
val tvosX64Main by getting {
dependsOn(darwinMain)
}
val tvosTest by getting {
val tvosX64Test by getting {
dependsOn(darwinTest)
}

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading