-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement option_simple_close
#2747
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2747 +/- ##
==========================================
- Coverage 86.30% 86.18% -0.13%
==========================================
Files 224 224
Lines 19867 20326 +459
Branches 795 805 +10
==========================================
+ Hits 17147 17517 +370
- Misses 2720 2809 +89
|
77023c5
to
db7a79d
Compare
a223c78
to
e05d16e
Compare
e05d16e
to
57ae172
Compare
3b6879b
to
4420858
Compare
4420858
to
7fda599
Compare
f8b957d
to
f0571b2
Compare
f0571b2
to
623b371
Compare
36ff0c3
to
3708ab9
Compare
This feature adds two new messages: - `closing_complete` sent after exchanging `shutdown` - `closing_sig` sent in response to `closing_complete`
The spec allows the closer to use an OP_RETURN output if their amount is too low when using `option_simple_close`.
We introduce a new `NEGOTIATING_SIMPLE` state where we exchange the `closing_complete` and `closing_sig` messages, and allow RBF-ing previous transactions and updating our closing script. We stay in that state until one of the transactions confirms, or a force close is detected. This is important to ensure we're able to correctly reconnect and negotiate RBF candidates. We keep this separate from the previous NEGOTIATING state to make it easier to remove support for the older mutual close protocols once we're confident the network has been upgraded.
3708ab9
to
ea979aa
Compare
Whenever one side sends `shutdown`, we restart a signing round from scratch. To be compatible with future taproot channels, we require the receiver to also send `shutdown` before moving on to exchanging `closing_complete` and `closing_sig`. This will give nodes a message to exchange fresh musig2 nonces before producing signatures. On reconnection, we also restart a signing session from scratch and discard pending partial signatures.
Whenever we exchange `shutdown`, we now require that new closing txs are signed before allowing another `shutdown` message to be sent to start a new signing round. This creates more risk of deadlock when one side fails to send their sigs, where we'll need to disconnect to start a new signing round. But that shouldn't happen if nodes are honest and not buggy, so it probably doesn't matter. If nodes are buggy or malicious, we will need to force-close anyway.
ea979aa
to
c45cf33
Compare
Closing in favor of #2967 |
Implement
option_simple_close
as defined in lightning/bolts#1096Hopefully this is the last time we change the mutual close protocol! And at some point that will let us entirely remove all the code supporting the two previous mutual close protocols (this is why I kept the code as separate as possible instead of trying to fit into the existing
NEGOTIATING
state).Note that this is a prerequisite for taproot channels: this protocol allows nodes to safely exchange nonces in
shutdown
andclosing_complete
to spend a musig2 channel output.