Implement shop_master_common #454
Conversation
There was a problem hiding this comment.
Firstly thanks so much for doing this!! This is a huge amount of progress since it's duplicated across every Nook actor! I've pointed out the most obvious things to me however I'll do a more thorough review when these are resolved and all the data is present!
include/ac_npc_shop_master.h
Outdated
| aNSC_MSG_PSWD_BAD = 0x144, | ||
| aNSC_MSG_PSWD_FOREIGN = 0x141, | ||
| aNSC_MSG_GIFT_OUT = 0x143, | ||
| aNSC_MSG_TAKE_OFF_HANDS= 0x108a, |
There was a problem hiding this comment.
This one appears to be the literal message ID instead of a relative value. It shouldn't be in this enum. You can add a definition for it in m_string_data.h if you'd like.
There was a problem hiding this comment.
They sort of are relative values; IDs 0-99 have one offset, IDs 100-199 are another, etc. (See https://github.com/colbyaustinbrown/ac-decomp/blob/1b4d4894b325ff1193276b6896d2701b4437a3bf/src/actor/npc/ac_npc_shop_master.c#L895). I can move them if you like, but thought I would give the extra context before I do.
|
Forgot to mention this earlier, but you should also run clang-format on the file! |
No description provided.