Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 3D Rendering API #104

Closed
wants to merge 11 commits into from
Closed

[WIP] 3D Rendering API #104

wants to merge 11 commits into from

Conversation

dylwhich
Copy link
Collaborator

@dylwhich dylwhich commented Oct 21, 2023

Description

This PR adds a simple 3D rendering API that can be used to draw arbitrary models, loaded as assets from .obj files.

Tasks Remaining

  • Fix king donut being shaded slightly wrong on hardware (lots of white triangles for some reason)
  • Figure out why the bunny rotates with the swadge and king donut rotates opposing the swadge -- it was an illusion!
  • Add translation/scaling parameters to drawModel()
  • Add parameters for drawing to a specific spot on-screen
  • Finish docs and cleanup

Test Instructions

Ticket Links

Readiness Checklist

  • I have run make format to format the changes
  • I have compiled the firmware and the changes have no warnings
  • I have compiled the emulator and the changes have no warnings
  • I have run make cppcheck and checked that cppcheck_result.txt has no warnings for the changes
  • I have added doxygen comments to any code used by more than one Swadge mode. This includes /*! \file comments with Design Philosophy, Usage, and Example sections for new headers.
  • I have run make docs and checked that doxy_warnings.txt has no warnings for the new code

@AEFeinstein
Copy link
Owner

LMK when this is actually ready for review and not WIP. I think github has a way to draft PRs. Maybe for next time.

@dylwhich dylwhich removed the request for review from AEFeinstein October 22, 2023 07:59
@dylwhich dylwhich marked this pull request as draft October 22, 2023 07:59
@dylwhich
Copy link
Collaborator Author

LMK when this is actually ready for review and not WIP. I think github has a way to draft PRs. Maybe for next time.

Ah, so you can. I could have sworn it automatically did that if you included WIP at some point.

@dylwhich dylwhich closed this Nov 1, 2023
@dylwhich dylwhich deleted the models-as-assets branch November 1, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants