Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a visual cue between images and videos #645

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Adds a visual cue between images and videos #645

wants to merge 8 commits into from

Conversation

jmafoster1
Copy link
Collaborator

@jmafoster1 jmafoster1 commented Oct 31, 2024 •
edited
Loading

  • I have added "Images" and "Videos" titles to the "Extracted media files" card.
    image
  • I have also moved "Select the media you would like to verify" as a subtitle rather than content within the card to make it more visually pleasing
  • I am filtering out single pixel tracking pngs as there's nothing to inspect here and it might confuse people (Question: Should we warn users when this occurs, or would it confuse them?)
  • I have added a light checkerboard background to make "white on transparent" PNG images visible, e.g.
    image

I am new to both this project and react, so any feedback on any of this would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosannamilner rosannamilner Awaiting requested review from rosannamilner

@Sallaa Sallaa Awaiting requested review from Sallaa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmafoster1