Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite & New features #5

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Rewrite & New features #5

wants to merge 10 commits into from

Conversation

AGuyNamedJens
Copy link
Owner

@AGuyNamedJens AGuyNamedJens commented Jan 26, 2022

This is a draft for new features within the FactorioChatBot
Feel free to commit updates.

Features:

  • Added support for nicknames from discord
  • Added deleteMessages option
  • Reformatted parseMessage
  • Prevent errors happening when sending messages
  • Add support to disable the sent message being returned by the bot
  • Add support for more information in the chat, such as when mentioning locations in-game
  • Add support for more events such as research_finished if possible
  • Rewrite documentation from the readme to the wiki pages
  • Optimize code

- Added deleteMessages option
- Reformatted parseMessage
- Prevent errors happening when sending messages
@AGuyNamedJens AGuyNamedJens self-assigned this Jan 26, 2022
@AGuyNamedJens AGuyNamedJens added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 26, 2022
@Mattie112
Copy link

Ah whoops I missed this! Feel free to close my MR in that case :)

@mikhailmikhalchuk
Copy link

Definitely willing to contribute to this. Noticed some of the content on my fork on the main, so I'm assuming it got some traction. Have we considered switching the main language to TypeScript?

@AGuyNamedJens
Copy link
Owner Author

@MikhailMCraft Hey, I never left this project behind, I just didn't get any new feature requests and i did indeed base some features and ideas from your fork.

I don't mind using typescript but wouldn't it make the "simple" bot, more advanced since building the TS files will be required?

I'm also considering automatic builds, which in this case would be the compiled files if we'll switch to typescript so the user won't have to compile everything on their own.

Let me know what you think.

@mikhailmikhalchuk
Copy link

Cool. In the future, it's prudent for both parties usually to approach the author of the fork when merging code upstream. I do not personally mind (and the license allows it regardless), but it is something to keep in mind.

TypeScript files do not have to be prebuilt and can just be built on runtime. There is virtually no change from JavaScript in terms of runtime building as it is around the same speed.

If there is a Discord server, or you have a Discord handle, I'd be more than glad to continue discussing this on there.

@AGuyNamedJens
Copy link
Owner Author

That's true. I might make a license change in the future to mention approaching the author when adding new features, would be a good idea to mention, wouldn't it?

Alright, in my own Discord bot project there's a huge difference between building and running directly, probably because it's larger than a 300-lined bot. We could indeed switch to typescript. Pre-builds would still probably be nice though.

I indeed have a discord server, feel free to join here

Add custom log file
Fix console messages appearently not logging properly to the console channel defined.
Added new listener for the custom events
Added ability to mute the Discord startup message
Add custom log file to config.json.example
- Changed parseMessage to Switch cases
- Added GPS, Train (Stop) location support
- Added warning support
- Remove includes, replace with indication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add more events besides join/leave and chat messages. No 'fancy' discord messages setting
3 participants