histogram #176
Merged
histogram #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
jim-smith
reviewed
Oct 18, 2023
There was a problem hiding this comment.
As it gets picked by the help command, perhaps we should change the doc string to make it clearer where we have diverged from pandas
- say that exactly one column must be specified
- also we take a. filename which data frame.hist perhaps doesn't
jim-smith
requested changes
Oct 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 99.61% 99.52% -0.09%
==========================================
Files 9 9
Lines 1038 1061 +23
==========================================
+ Hits 1034 1056 +22
- Misses 4 5 +1
|
jim-smith
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.