Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pandas version 2 #237

Merged
merged 4 commits into from
Oct 22, 2024
Merged

add support for pandas version 2 #237

merged 4 commits into from
Oct 22, 2024

Conversation

rpreen
Copy link
Collaborator

@rpreen rpreen commented Oct 17, 2024

Some (minor) changes for compatibility with Pandas >=2.

Resolves #149

  • No functional changes were required that modify existing behaviour;
  • Changes dependencies to allow pandas v2: pandas>1.5.0,<2.3
    • This means that pandas no longer has to be built from source for Python 3.12 (more seamless install)
  • Drops Python 3.8, which is end of life
  • Adds Python 3.13 (but see notes)
  • CI confirms Python 3.9--3.12 all work on ubuntu, Windows, and macOS;
  • CI confirms Python 3.13 works on ubuntu and macOS; however pytest fails on Windows with Windows fatal exception: access violation probably due to numpy (see below); so this has been put in a separate CI runner
  • Python 3.13 manual installation/tests in a Windows VM: numpy was able to be built from source and the tests all completed fine with the exception of some error about tkinter, which seems to be a generic issue with running tkinter in virtual environments with Python 3.13
  • Test notebook produces same output with Pandas 1.5.3 and 2.2.3
  • Bumps acro version to v0.4.7

Note:

Numpy only has wheels for Python 3.13 for version >=2.1 so it has to be built from source (requiring C++ build tools) for the version acro currently uses: 1.26.4 since we do not support version 2 yet. The note in the README has been updated to reflect this.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (9cf620d) to head (04425eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files           9        9           
  Lines        1199     1201    +2     
=======================================
+ Hits         1189     1191    +2     
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpreen rpreen changed the title pandas >2 compatibility add support for pandas version 2 Oct 22, 2024
@rpreen rpreen marked this pull request as ready for review October 22, 2024 11:29
@rpreen rpreen merged commit 015b5dd into main Oct 22, 2024
18 checks passed
@rpreen rpreen deleted the pandas_2 branch October 22, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency versions
1 participant