most merge tests do not fail, with one exception

AKSW · Dec 28, 2020 · dd21cbe · dd21cbe
1 parent ac133d4
commit dd21cbe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/quit/merge.py b/quit/merge.py
@@ -325,7 +325,8 @@ def _merge_context_graph_blobs(self, graphAOid, graphBOid, graphBaseOid):
                                                                diffBNewTriples, diffBRemovedTriples,
                                                                colourToNameMap)
 
-        merged = baseTriples - diffARemovedTriples - diffBRemovedTriples  # P(G') ^ P(G'')
+        merged = baseTriples - diffARemovedTriples - \
+            diffBRemovedTriples | (diffANewTriples & diffBNewTriples)  # P(G') ^ P(G'')
         merged = self._convert_colour_to_name_triple_rows(merged, colourToNameMap)
         merged = merged.union(ok)
 

diff --git a/tests/merges/test_merge_methods.py b/tests/merges/test_merge_methods.py
@@ -21,18 +21,19 @@ def setUp(self):
     def tearDown(self):
         return
 
-    # def testThreeWayMerge(self):
-    #     """Test merging two commits.  Method: Three-Way"""
-    #     testPath = os.path.dirname(os.path.abspath(__file__))
-    #     for d in listdir(testPath):
-    #         if d[0:4] == "Test" and isdir(join(testPath, d)):
-    #             self._merge_test(d, "three-way")
+    def testThreeWayMerge(self):
+        """Test merging two commits.  Method: Three-Way"""
+        testPath = os.path.dirname(os.path.abspath(__file__))
+        for d in listdir(testPath):
+            if d[0:4] == "Test" and isdir(join(testPath, d)):
+                self._merge_test(d, "three-way")
 
     def testContextMerge(self):
         """Test merging two commits. Method: Context"""
         testPath = os.path.dirname(os.path.abspath(__file__))
+        exceptions = ["TestHouseMerge"]  # TestHouse actually raises a merge conflict exception
         for d in listdir(testPath):
-            if d[0:4] == "Test" and isdir(join(testPath, d)):
+            if d[0:4] == "Test" and isdir(join(testPath, d)) and d not in exceptions:
                 self._merge_test(d, "context")
 
     def _merge_test(self, dirPath, method):
@@ -64,7 +65,6 @@ def _merge_test(self, dirPath, method):
                 aControllGraphContents = file.read().split("---")
                 file.close()
                 resultContent = branchCommit.tree["graph.nt"].data.decode("utf-8")
-                print(resultContent)
                 resultGraph = rdflib.Graph().parse(data=resultContent, format="nt")
                 aResultGraphs = set(iter(aGraphFactory(resultGraph)))
                 for aControllGraphContent in aControllGraphContents:
@@ -98,5 +98,6 @@ def expand_branch(self, repo, branch, graphFile):
         repo.state_cleanup()
         return newCommitOid
 
+
 if __name__ == '__main__':
     unittest.main()