This repository has been archived by the owner on Jun 17, 2019. It is now read-only.
Changed Task Generation to be Cross Platform #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trying to run the generator on my Arch Linux WSL environment, I saw that there were some files that were failing to be copied (breaking the whole process) due to capitalization. Also modified the tastTests to be more OS safe. Windows doesn't seem to care about paths with "/" but Arch hates "\" in paths
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying to run the generator on my Arch Linux WSL environment, I saw that there were some files that were failing to be copied (breaking the whole process) due to mismatch from file and config capitalization. This isn't an issue in Windows due to the file system being case insensitive, but is an issue in Linux.
Main problem with the Task Generator was the capitalization of the "tasks" source folder when copying files to the generator output folder. There was also a mismatch for the screenshot file.
The problems with the tests was both capitalization and file paths being Windows specific.
Also modified the taskTests to be more OS safe. Windows doesn't seem to care about paths with "/" but Linux/Node does not agree with "" in paths.
Please let me know if this type of work is appreciated and I can look at the rest of the generators. ❤️
@ALM-Rangers/generator-vsts-extension