add method that calls register_all in api (Shopify#1743)

* add method that calls register_all in api * Changelog * explict argument hash style * rubocop
AMPeCommerce · Oct 31, 2023 · 40aaa60 · 40aaa60
1 parent 0eec265
commit 40aaa60
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 Unreleased
 ----------
+* Fixes bug with `WebhooksManager#recreate_webhooks!` where we failed to register topics in the registry[#1743](https://github.com/Shopify/shopify_app/pull/1704)
 
 21.7.0 (Oct 12, 2023)
 ----------

diff --git a/lib/shopify_app/managers/webhooks_manager.rb b/lib/shopify_app/managers/webhooks_manager.rb
@@ -26,6 +26,7 @@ def recreate_webhooks!(session:)
 
         ShopifyApp::Logger.debug("Recreating webhooks")
         add_registrations
+        create_webhooks(session: session)
       end
 
       def destroy_webhooks(session:)

diff --git a/test/shopify_app/managers/webhooks_manager_test.rb b/test/shopify_app/managers/webhooks_manager_test.rb
@@ -83,6 +83,7 @@ class ShopifyApp::WebhooksManagerTest < ActiveSupport::TestCase
 
     ShopifyApp::WebhooksManager.expects(:destroy_webhooks)
     ShopifyApp::WebhooksManager.expects(:add_registrations)
+    ShopifyApp::WebhooksManager.expects(:create_webhooks).with(session: session)
 
     ShopifyApp::WebhooksManager.recreate_webhooks!(session: session)
   end