Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update submodules when doing git fetch #149

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BenWibking
Copy link
Contributor

@BenWibking BenWibking commented Dec 13, 2024

This updates submodules with git submodule update --init after updating the git commit.

--init is required because there may be new submodules since the last checkout.

We need this for the Quokka GPU regression tests to work properly.

@zingale
Copy link
Member

zingale commented Dec 14, 2024

I think that this should be opt-in. For instance, with Castro, we can use submodules, but we don't for testing, so I don't want it to create submodules when testing.

@BenWibking
Copy link
Contributor Author

I think that this should be opt-in. For instance, with Castro, we can use submodules, but we don't for testing, so I don't want it to create submodules when testing.

Ok, I've created a new option in the ini file for this. Let me know how it looks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants